fix(mysql): orc memberLeave uses the contract member identity and fails closed#3096
Draft
weicao wants to merge 1 commit into
Draft
fix(mysql): orc memberLeave uses the contract member identity and fails closed#3096weicao wants to merge 1 commit into
weicao wants to merge 1 commit into
Conversation
…ls closed Target KB_LEAVE_MEMBER_POD_NAME (05b memberLeave contract) instead of the execution pod's name, falling back only when unset. Verify Orchestrator reachability before interpreting an empty instance query as "forgotten" - an Orchestrator outage previously made scale-in report success without deregistering the member. Fixes #3095 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3096 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 144 144
Lines 23013 23013
=====================================
Misses 23013 23013 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3095.
Two scoped changes in
orc-member-leave.sh:leave_member="${KB_LEAVE_MEMBER_POD_NAME:-${KB_AGENT_POD_NAME}}"— the 05b contract variable, with the old behavior as explicit fallback; forget/verify/log all use it.-c clusters) before treating an empty-c instanceresult as "forgotten", because outage and absence are otherwise indistinguishable. Outage → exit 1 (kbagent retry), absence → success, still-present → exit 1 (unchanged).Validation:
bash -npass. Runtime matrix before undraft: normal scale-in (member forgotten, Ops succeeds); scale-in with Orchestrator down (action fails, retries after recovery); scale-in where the action executes on a pod other than the leaving member.🤖 Generated with Claude Code