fix(mysql): honor image.pullPolicy (reversed sprig default args)#3094
Draft
weicao wants to merge 1 commit into
Draft
fix(mysql): honor image.pullPolicy (reversed sprig default args)#3094weicao wants to merge 1 commit into
weicao wants to merge 1 commit into
Conversation
'default .Values.image.pullPolicy "IfNotPresent"' puts the fallback second, so it always yielded IfNotPresent and the values key was silently ignored at 20+ container sites; the exporter helper hardcoded it outright. Normalize every site to 'default "IfNotPresent" .Values.image.pullPolicy'. Fixes #3093 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3094 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 144 144
Lines 23013 23013
=====================================
Misses 23013 23013 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3093.
Mechanical, render-verified fix: swap the sprig
defaultarguments at every reversed site (cmpd-mysql57/80/84, mgr and orc variants,_orc.tpl) and replace the exporter helper's hardcodedimagePullPolicy: IfNotPresentwith the same expression.Verification:
helm template --set image.pullPolicy=Always→ 35/35 sites renderAlways(main renders 21 stuck atIfNotPresent)IfNotPresent(unchanged behavior when the value is unset)🤖 Generated with Claude Code