fix(postgresql): remove static IMAGE_TAG fallback that hid version-mapping misses#3063
Draft
weicao wants to merge 1 commit into
Draft
fix(postgresql): remove static IMAGE_TAG fallback that hid version-mapping misses#3063weicao wants to merge 1 commit into
weicao wants to merge 1 commit into
Conversation
…pping misses Four ActionSets defaulted IMAGE_TAG to 14.8.0-pgvector-v0.6.1. The BPT's per-method versionMapping overrides it for every serviceVersion declared in the chart, so the default only ever fired on a mapping miss (e.g. a custom ComponentVersion minor) — silently running a PG 16/17/18 cluster's backup/restore tooling with the PG 14 image. The defaults are removed; on a miss the image now renders with a literal $(IMAGE_TAG) tag and the job fails visibly at image resolution, naming the unexpanded variable. pgdumpall's env block became empty and is dropped. wal-g / wal-g-incremental are unaffected (fixed walgImage helper, no IMAGE_TAG). Fixes #3062 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3063 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 144 144
Lines 23013 23013
=====================================
Misses 23013 23013 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Deep-review finding 三.19 (issue #3062): four ActionSets (postgresql-pitr, pgbasebackup, wal-g-pitr, pgdumpall) default
IMAGE_TAGto14.8.0-pgvector-v0.6.1. The BPT'sversionMappingoverrides it whenever the target serviceVersion is in the chart's declared versions — so the static default only ever takes effect on a mapping miss, at which point a PG 16/17/18 cluster silently runs its backup/restore tooling with the PG 14 image. Wrong-majorpg_dump/pg_basebackup/wal-gshould fail loudly, not run quietly.Change
Remove the four static defaults (and the now-empty
env:block in pgdumpall). On a mapping miss the image renders with a literal$(IMAGE_TAG)tag → the job fails at image resolution with the unexpanded variable in the error — attributable fail-fast.wal-g/wal-g-incrementalmethods are unaffected (fixedwalgImagehelper).Evidence boundary
Static + rendered chart: the only remaining
14.8.0-pgvectoroccurrences are the 14.8.0 serviceVersion's own mapping entries and the pg14 cmpd/cmpv images (legitimate). Not runtime-tested; the change removes a fallback rather than altering any matched-path behavior.🤖 Generated with Claude Code