fix(mariadb): remove silent-no-op Galera memberLeave action#3055
Draft
weicao wants to merge 1 commit into
Draft
Conversation
The Galera memberLeave ran galera-member-leave.sh in the kbagent execution face (container: mariadb, no exec.image), which has no mariadb client, and every SQL was guarded with 2>/dev/null || true — so the claimed FLUSH TABLES / wsrep_desync=ON never executed and it exited 0. It also never checked KB_LEAVE_MEMBER_POD_NAME. Removal is the correct fix: Galera evicts a departed node natively via keepalive timeout, and the shutdown-time graceful leave (final seqno + safe_to_bootstrap, clean InnoDB flush) is already handled by the mariadb container preStop running in-container against 127.0.0.1 — wsrep_on=OFF subsumes wsrep_desync=ON. Making the action work via exec.image would only duplicate preStop with a new failure surface. Remove the memberLeave action, the script mount, and the script; add a contract spec. helm renders; full mariadb suite green (656 examples). Fixes #3053
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3055 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 142 143 +1
Lines 22841 22876 +35
=====================================
- Misses 22841 22876 +35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3053 — the Galera memberLeave ran in kbagent (no mariadb client), so its FLUSH/desync SQL was a swallowed no-op.
Rationale for removal (not exec.image) in the issue: Galera auto-evicts departed nodes, and the shutdown graceful-leave is already done by the in-container preStop (wsrep_on=OFF subsumes wsrep_desync=ON). Change: remove action + script mount + script; add contract spec.
Validation: helm renders (no memberLeave / no galera-member-leave.sh refs), full mariadb shellspec green (656 examples, 0 failures, 9 pre-existing pendings). mariadb team full-suite verification per westonnnn.