Skip to content

Remove last open read cache#13248

Open
JosiahWI wants to merge 2 commits into
apache:masterfrom
JosiahWI:feat/remove-last-open-read
Open

Remove last open read cache#13248
JosiahWI wants to merge 2 commits into
apache:masterfrom
JosiahWI:feat/remove-last-open-read

Conversation

@JosiahWI

@JosiahWI JosiahWI commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

It was discussed in #13061 that the one disk read rarely saved with the last open read cache is probably fine on today's SSDs. Removing the optimization simplifies the cache.

Fixes #13095

@JosiahWI JosiahWI added this to the 11.0.0 milestone Jun 8, 2026
@JosiahWI JosiahWI self-assigned this Jun 8, 2026
Copilot AI review requested due to automatic review settings June 8, 2026 12:34
@JosiahWI JosiahWI added the Cache label Jun 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@masaori335

Copy link
Copy Markdown
Contributor

Our benchmark says below.

Scenario no last-open-read 10.2.0 (vanilla) Δ
max-tps-10url (plain text) 441,754 req/s 564,269 req/s −122,515 req/s (−21.7%)
max-tps-10url-tls 505,910 req/s 505,717 req/s +193 req/s (+0.0%)
max-tps-10url-h2 463,392 req/s 465,356 req/s −1,964 req/s (−0.4%)
max-tps-100url (plain text) 514,221 req/s 578,793 req/s −64,572 req/s (−11.2%)
max-tps-100url-tls 517,851 req/s 524,341 req/s −6,490 req/s (−1.2%)
max-tps-100url-h2 481,452 req/s 487,708 req/s −6,256 req/s (−1.3%)

Hardware & Config Info

  • CPU: Intel(R) Xeon(R) Gold 5218 64 core
  • 40 Stripes = 8 (NVME SSD Drive) x 5 (Volumes)
  • Thread configs in records.yaml
  exec_thread:
    affinity: 4
    limit: 63
    listen: 1

The mini-cache (last-open-read) is working even if target URL is 100. Now, I'm wondering we should fix the small RAM cache promotion bug and keep this mini cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove last_open_read memory cache feature

3 participants