Skip to content

Add in a vendor copy of Google Highway#13228

Open
phongn wants to merge 3 commits into
apache:masterfrom
phongn:highway
Open

Add in a vendor copy of Google Highway#13228
phongn wants to merge 3 commits into
apache:masterfrom
phongn:highway

Conversation

@phongn

@phongn phongn commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Google Highway is a C++ library that provides portable SIMD/vector intrinsics. It currently supports all targets that ATS intends to build for (notably x86_64 and aarch64), and offers runtime dynamic dispatch.

Profiling of ATS indicates we have a number of string processing hotspots that are amenable to vector acceleration. However, each microarchitecture has different intrinsics and on x86_64 this varies wildly. Rather than take up the maintenance burden of maintaining and updating hand-written intrinsic code, we instead can use Highway to generate it for us.

This pull request adds a snapshot of Highway 1.4.0, but without tests, documentation or non-CMake build infrastructure.

@phongn phongn added this to the 11.0.0 milestone Jun 2, 2026
@phongn phongn added the dependencies Pull requests that update a dependency file label Jun 2, 2026
@masaori335

Copy link
Copy Markdown
Contributor

Do we really need to copy the lib in our repo? I thought let CMake to find the external library like what we do for jemalloc, hwloc, ...etc.

https://github.com/apache/trafficserver/blob/master/cmake/Findjemalloc.cmake
https://github.com/apache/trafficserver/blob/master/cmake/Findhwloc.cmake

@masaori335

Copy link
Copy Markdown
Contributor

NVM, we agreed with vendor copy at weekly bug scrub.

@bryancall bryancall requested review from Copilot and masaori335 June 8, 2026 22:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@masaori335 masaori335 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants