Skip to content

Fix CloudTruth project name in publish workflow#3450

Closed
alekseidudchenko-osp wants to merge 1 commit into
apache:masterfrom
alekseidudchenko-osp:master
Closed

Fix CloudTruth project name in publish workflow#3450
alekseidudchenko-osp wants to merge 1 commit into
apache:masterfrom
alekseidudchenko-osp:master

Conversation

@alekseidudchenko-osp
Copy link
Copy Markdown

@alekseidudchenko-osp alekseidudchenko-osp commented May 8, 2026

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@mergeable mergeable Bot added the github_actions Pull requests that update GitHub Actions code label May 8, 2026
@alekseidudchenko-osp alekseidudchenko-osp changed the title Fix CloudTruth project name in publish workflow THRIFT-5972: Fix CloudTruth project name in publish workflow May 8, 2026
@alekseidudchenko-osp
Copy link
Copy Markdown
Author

@Jens-G this should fix the 'publish 0.23.0 to public Maven' pipeline problem.

runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v6
with:
persist-credentials: false
submodules: recursive
- uses: actions/setup-python@v6
@@ -0,0 +1,52 @@
#
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASF header missing

@Jens-G Jens-G self-requested a review May 9, 2026 12:09
Copy link
Copy Markdown
Member

@Jens-G Jens-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jens-G this should fix the 'publish 0.23.0 to public Maven' pipeline problem.

Can you explain what the idea is here? It worked before without that, so I would like at least a bit more information than "this solves some problem" which is not even described at all. As it stands, it is not a proper description of any kind.

@kpumuk
Copy link
Copy Markdown
Member

kpumuk commented May 9, 2026

This is a Python library release action on pypi, that mostly duplicates another one in https://github.com/apache/thrift/blob/master/.github/workflows/pypi.yml workflow. What's the purpose of this change? Also, see #3440

@Jens-G Jens-G changed the title THRIFT-5972: Fix CloudTruth project name in publish workflow Fix CloudTruth project name in publish workflow May 10, 2026
@Jens-G Jens-G closed this May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants