Skip to content

Fix: surface HTTP 413 and other 4xx errors via replication error event (issue #9165) #9236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TeapoyY wants to merge 1 commit into from
+5 −0
Closed

Fix: surface HTTP 413 and other 4xx errors via replication error event (issue #9165) #9236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/node_modules/pouchdb-replication/src/replicate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,11 @@ function replicate(src, target, opts, returnValue, result) {
if (errorName === 'unauthorized' || errorName === 'forbidden') {
returnValue.emit('error', fatalError);
returnValue.removeAllListeners();
} else if (fatalError.status >= 400 && fatalError.status < 500) {
// Surface 4xx client errors (e.g. 413 Content Too Large from _bulk_docs)
// via the error event instead of retrying, since retrying won't fix them.
returnValue.emit('error', fatalError);
returnValue.removeAllListeners();
} else {
backOff(opts, returnValue, fatalError, function () {
replicate(src, target, opts, returnValue);
Expand Down