apps/bttester: fix address lookup in gap_conn_find_by_addr - #2284
Open
piotrnarajowski wants to merge 1 commit into
Open
apps/bttester: fix address lookup in gap_conn_find_by_addr#2284piotrnarajowski wants to merge 1 commit into
piotrnarajowski wants to merge 1 commit into
Conversation
Comment on lines
+104
to
+105
| if ((addr.type & 2) == 0) { | ||
| addr.type |= 2; |
Contributor
There was a problem hiding this comment.
Maybe instead of "2" we can use the definitions of this number? (BLE_ADDR_PUBLIC_ID if I'm not mistaken).
szymon-czapracki
suggested changes
Aug 18, 2026
piotrnarajowski
force-pushed
the
find_by_addr_fix
branch
from
August 19, 2026 14:42
51a0e13 to
454f126
Compare
szymon-czapracki
approved these changes
Aug 19, 2026
Contributor
Author
|
#AutoPTS run mynewt GATT/SR/GAN/BV-02-C |
|
Scheduled PR #2284 (comment), board: nrf52, estimated start time: 09:13:38, test case count: 1, estimated duration: 0:11:14 Test cases to be runGATT/SR/GAN/BV-02-C |
|
AutoPTS Bot results: Successful tests (1)GATT GATT/SR/GAN/BV-02-C PASS |
sjanc
reviewed
Sep 8, 2026
sjanc
left a comment
sjanc
left a comment
Contributor
There was a problem hiding this comment.
shouldn't those global peer_ota_addr and peer_id_addr be also removed from code?
gap_conn_find_by_addr lookup relied on the global peer_id_addr variable to perform address matching. In test cases with multiple concurrent connections, peer_id_addr was overwritten by the most recent event (e.g. connected, identity resolved) causing comparison with address command parameter in BTP cmds to fail. Remove peer_id_addr and peer_ota_addr.
piotrnarajowski
force-pushed
the
find_by_addr_fix
branch
from
September 9, 2026 10:04
454f126 to
19d9f79
Compare
Contributor
Author
Yes, it is safe to remove them. |
Contributor
Author
|
#AutoPTS run mynewt GAP --test_case_limit 10 |
|
Scheduled PR #2284 (comment), board: nrf52, estimated start time: 12:09:55, test case count: 10, estimated duration: 0:13:45 Test cases to be runGAP/BROB/BCST/BV-01-CGAP/BROB/BCST/BV-02-C GAP/BROB/BCST/BV-03-C GAP/BROB/BCST/BV-04-C GAP/BROB/BCST/BV-05-C GAP/BROB/OBSV/BV-01-C GAP/BROB/OBSV/BV-02-C GAP/BROB/OBSV/BV-05-C GAP/BROB/OBSV/BV-06-C GAP/DISC/NONM/BV-01-C |
|
AutoPTS Bot results: Failed tests (1)GAP GAP/BROB/BCST/BV-04-C BTP ERROR - ERRATA https://github.com//issues/1029Successful tests (9)GAP GAP/BROB/BCST/BV-01-C PASSGAP GAP/BROB/BCST/BV-02-C PASS GAP GAP/BROB/BCST/BV-03-C PASS GAP GAP/BROB/BCST/BV-05-C PASS GAP GAP/BROB/OBSV/BV-01-C PASS GAP GAP/BROB/OBSV/BV-02-C PASS GAP GAP/BROB/OBSV/BV-05-C PASS GAP GAP/BROB/OBSV/BV-06-C PASS GAP GAP/DISC/NONM/BV-01-C PASS |
sjanc
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gap_conn_find_by_addr lookup relied on the global peer_id_addr variable to perform address matching. In test cases with multiple concurrent connections, peer_id_addr was overwritten by the most recent event (e.g. connected, identity resolved) causing comparison with address command parameter in BTP cmds to fail.