KAFKA-20532: Defensive trimming of min.insync.replicas in controller and kafka-topics to tolerate whitespace-contaminated configs#22453
Open
sahildevgon wants to merge 1 commit into
Open
Conversation
…and kafka-topics to tolerate whitespace-contaminated configs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary :
Whitespace-contaminated min.insync.replicas values silently accepted at write time cause a controller failover loop and full cluster unavailability with no operator-visible warning, because the --describe observability path trims whitespace before displaying the value.
Impact
A topic config min.insync.replicas stored with leading or trailing whitespace (e.g. " 2") causes the KRaft controller to enter a continuous failover loop, making the cluster unavailable. The crash is triggered on every alterPartition event (e.g. any replica
restart), so recovery is not spontaneous. Critically, kafka-topics.sh --describe silently strips the whitespace before displaying the value, so the corrupted config is invisible to operators. There is no log warning, no alert, and no way to detect the problem via the standard Admin API observability path. An operator can stare at a failing cluster and see only
clean config values.
More Details in JIRA : https://issues.apache.org/jira/browse/KAFKA-20532