KAFKA-14597: record-e2e-latency-max only considers consumption latencies but not processing delays#22452
Open
alanlau28 wants to merge 2 commits into
Open
Conversation
…ies but not processing delays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-14597
The
record-e2e-latencymetric at terminal nodes was computed ascurrentSystemTimeMs() - record.timestamp(), wherecurrentSystemTimeMs()returns a wall-clock value cached once at the start of processing a record (set byupdateProcessorContextbeforecurrNode.process()runs). Because this value is captured before the topology executes, processing delays are invisible to it.The fix reads the wall clock freshly at the terminal site, after
child.process()returns. To avoid a clock read per output record the read is done lazily:currentRecordE2ELatencyTimeMsonStreamTaskcaches the first fresh read and is reused for every subsequent terminal recording within the same input record's processing.updateProcessorContextresets the field to-1at the start of each record and punctuation, so each input record gets its own reading taken after its processing completes.