MINOR: Correcting reviewers script for names#22449
Open
apoorvmittal10 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reviewers.py script incorrectly parses reviewer names that start
with characters appearing in "Author:" or "Reviewers:", leading to
truncated names.
Issue
stripped = line.strip().lstrip("Reviewers: ").lstrip("Author: ")
The Problem: lstrip(string) does not remove a prefix string. Instead, it
removes any characters from that character set from the left side of the
string.
Fix
Replace the buggy lstrip() calls with proper prefix removal. Two options
available:
Option 1: Using removeprefix() (Python 3.9+)
Requires Python 3.9+
Option 2: Using startswith() (Python 3.0+)
Used option 2 as the script currently supports Python 3+
Example Issue:
When searching for "Apoorv", the script showed: