KAFKA-20072 Make Uuid no-dash behavior opt-in#22442
Open
mumrah wants to merge 2 commits into
Open
Conversation
Member
Author
nileshkumar3
reviewed
Jun 1, 2026
Contributor
nileshkumar3
left a comment
There was a problem hiding this comment.
Nice, clear change making the no-dash behavior opt-in via randomUuidNoDashes() and using it in ReplicationControlManager#createTopic — that matches the intent of KAFKA-20072 for topic IDs. Should bin/kafka-storage.sh random-uuid, or any other operator-facing ID generation sites, remain unchanged, or would it make sense to consider them as a follow-up?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of changing
Uuid#randomUuidto always have the new behaviorintroduced in #21313, this patch moves the new logic into a separate
randomUuidNoDashesmethod.Since Uuid is a utility class, it is used widely throughout the broker
and client (possibly even applications). In most cases, the presence of
a dash is inconsequential. The new behavior, which comes with a small
performance hit, should not affect these callers. The introduction of a
new Uuid factory makes the new behavior opt-in.
One caller is updated to use the new factory which is where the
controller allocates topic IDs. This matches the intention of the
original Jira.