Skip to content

KAFKA-19193: throw ConfigException if rack is empty in rack-aware mode #22433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivanyu wants to merge 1 commit into
base: trunk
Choose a base branch
from
+2 −1
Open

KAFKA-19193: throw ConfigException if rack is empty in rack-aware mode #22433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.apache.kafka.common.PartitionInfo;
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.common.compress.Compression;
import org.apache.kafka.common.config.ConfigException;
import org.apache.kafka.common.header.Header;
import org.apache.kafka.common.metrics.Metrics;
import org.apache.kafka.common.record.TimestampType;
Expand Down Expand Up @@ -1240,7 +1241,7 @@ public PartitionerConfig(boolean enableAdaptivePartitioning, long partitionAvail
this.rack = rack;

if (rackAware && Utils.isBlank(rack)) {
throw new IllegalArgumentException("client.rack must be provided if partitioner.rack.aware is enabled");
throw new ConfigException("client.rack must be provided if partitioner.rack.aware is enabled");
}
}

Expand Down