KAFKA-20646: Use Locale.ROOT in String.format() calls in tools/ and s…#22428
Open
vanba4772 wants to merge 2 commits into
Open
KAFKA-20646: Use Locale.ROOT in String.format() calls in tools/ and s…#22428vanba4772 wants to merge 2 commits into
vanba4772 wants to merge 2 commits into
Conversation
…erver-common/ String.format() without a Locale parameter can produce locale-dependent output (e.g., different decimal separators), which is inconsistent with the project's existing practice of using Locale.ROOT for toLowerCase() and toUpperCase() calls. This commit adds Locale.ROOT as the first argument to all String.format() calls in the tools/ and server-common/ modules. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.format() without a Locale parameter can produce locale-dependent output (e.g., different decimal separators for numbers, locale-specific formatting). This is inconsistent
with the project's existing checkstyle rule that enforces Locale.ROOT for toLowerCase() and toUpperCase() calls.
The tools/ and server-common/ modules contain ~75 occurrences of String.format( without an explicit Locale. These should be changed to String.format(Locale.ROOT, ...) for
consistent, locale-independent behavior.