KAFKA-18862: Consolidate shared heartbeat request manager tests#22425
Open
nileshkumar3 wants to merge 1 commit into
Open
KAFKA-18862: Consolidate shared heartbeat request manager tests#22425nileshkumar3 wants to merge 1 commit into
nileshkumar3 wants to merge 1 commit into
Conversation
github-actions
Bot
added
consumer
tests
nileshkumar3
force-pushed
the
KAFKA-18862
branch
6 times, most recently
from
92e558f to
5e01cff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Duplicate heartbeat poll/timing and error-handling tests in
ConsumerHeartbeatRequestManagerTestandShareHeartbeatRequestManagerTesthad drifted out of sync (KAFKA-18862). This consolidates shared behavior intoAbstractHeartbeatRequestManagerTest, which both subclasses extend.Shared tests now live in one place; Consumer and Share only implement
createHeartbeatResponse()for their respective RPC types and retain their manager-specific tests.Moved to the base class:
testTimerNotDuetestHeartbeatOutsideIntervaltestNoCoordinatortestPollTimerExpirationShouldNotMarkMemberStaleIfMemberAlreadyLeavingtestSuccessfulHeartbeatTimingtestGroupIdNotFoundExceptionWhileUnsubscribedtestGroupIdNotFoundWhileStableIsFataltestHeartbeatResponseOnErrorHandling(with sharederrorProvider())This also aligns Share error coverage with Consumer (e.g.
FENCED_INSTANCE_ID,TOPIC_AUTHORIZATION_FAILED).Reviewer - @AndrewJSchofield