action-allowlist-review: bump rubygems/configure-rubygems-credentials from 1.0.0 to 2.0.0 in /.github/actions/for-dependabot-triggered-reviews#795
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
the
github_actions
Member
|
@dependabot rebase |
dependabot
Bot
force-pushed
the
dependabot/github_actions/dot-github/actions/for-dependabot-triggered-reviews/rubygems/configure-rubygems-credentials-2.0.0
branch
from
f9213c5 to
3fe8811
Compare
ppkarwasz
approved these changes
May 4, 2026
Member
ppkarwasz
left a comment
ppkarwasz
left a comment
There was a problem hiding this comment.
LGTM, this action is:
- Signed by a core team member if RubyGems,
- The code (much shorter than the diff) looks good,
- The invocations of
HttpClientare false positives and are used for API calls, not downloads.
Member
Agree. Let me add a fix to detect those cases as false positives. |
Member
|
Ah yeah the false positive was fixed in #790 -> let me rebase and hopefully this one gets green. |
Member
|
@dependabot rebase |
potiuk
approved these changes
May 4, 2026
Bumps [rubygems/configure-rubygems-credentials](https://github.com/rubygems/configure-rubygems-credentials) from 1.0.0 to 2.0.0. - [Release notes](https://github.com/rubygems/configure-rubygems-credentials/releases) - [Commits](rubygems/configure-rubygems-credentials@bc6dd21...762a4b7) --- updated-dependencies: - dependency-name: rubygems/configure-rubygems-credentials dependency-version: 2.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/github_actions/dot-github/actions/for-dependabot-triggered-reviews/rubygems/configure-rubygems-credentials-2.0.0
branch
from
3fe8811 to
fb022a6
Compare
3 tasks
Member
|
Ah... Typescript typing 🤦 - fixed detection in #798 |
Member
|
It passes the test with #798: 
|
potiuk
deleted the
dependabot/github_actions/dot-github/actions/for-dependabot-triggered-reviews/rubygems/configure-rubygems-credentials-2.0.0
branch
potiuk
added a commit
that referenced
this pull request
May 5, 2026
…calls Commit 920d616 added postJson/getJson/etc. as data-parse markers but the regex required `(` directly after `Json`. The real call site in rubygems/configure-rubygems-credentials v2.0.0 is `http.postJson<IdToken>(...)` — the TypeScript generic between `Json` and `(` defeated the match, so PR #795 still showed both src/oidc/assumeRole.ts and trustedPublisher.ts as unverified downloads. Allow an optional `<...>` between `Json` and `(`, and tighten the RUBYGEMS_OIDC_EXCHANGE fixture so it mirrors the v2.0.0 source verbatim (including the generic and IdTokenSchema.parse on the result). The fixture omitting the generic was the crack the original fix slipped through.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps rubygems/configure-rubygems-credentials from 1.0.0 to 2.0.0.
Release notes
Sourced from rubygems/configure-rubygems-credentials's releases.
Commits
762a4b7Exclude dependabot updates from release note720fbb1Merge pull request #401 from rubygems/dependabot/npm_and_yarn/types/node-25.6.07609dc5Merge pull request #400 from rubygems/dependabot/npm_and_yarn/typescript-esli...97eb064Bump@types/nodefrom 22.9.1 to 25.6.03561a05Bump@typescript-eslint/parserfrom 8.58.2 to 8.59.1cb08873Merge pull request #394 from rubygems/dependabot/github_actions/zizmorcore/zi...aa6ce95Merge pull request #395 from rubygems/dependabot/github_actions/github/codeql...83bda94Merge pull request #396 from rubygems/dependabot/npm_and_yarn/eslint-plugin-j...a44a37cMerge pull request #397 from rubygems/dependabot/github_actions/actions/setup...c99d6f3Bump actions/setup-node from 6.3.0 to 6.4.0