Parquet: Fix decimal and UUID filter pushdown conversion#16621
Open
alexandrefimov wants to merge 1 commit into
Open
Parquet: Fix decimal and UUID filter pushdown conversion#16621alexandrefimov wants to merge 1 commit into
alexandrefimov wants to merge 1 commit into
Conversation
113c045 to
5c3405b
Compare
Author
|
This is ready for review. For context, this picks up the work from #16051, which was closed as stale. This version keeps the same issue scope but also uses the Parquet physical type when converting decimal literals, covers INT32/INT64/BINARY/FIXED_LEN_BYTE_ARRAY decimal encodings, and adds UUID logical type conversion coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Parquet filter pushdown conversion for decimal and UUID predicates.
Changes:
MessageTypewhen building the pushed Parquet filter so decimal predicates use the actual physical primitive type.INT32,INT64,BINARY, andFIXED_LEN_BYTE_ARRAYencodings.NOOPwhen decimal literals cannot be represented safely at the file schema scale/precision.UUIDTypeso UUID predicates bind correctly.Tests:
./gradlew :iceberg-parquet:spotlessCheck :iceberg-parquet:testCloses #16035