Build: Ban Preconditions.checkState with %d placeholder#16407
Open
ebyhr wants to merge 1 commit into
Open
Conversation
ebyhr
force-pushed
the
ebi/build-preconditions
branch
from
39d56ca to
93c69f3
Compare
ebyhr
force-pushed
the
ebi/build-preconditions
branch
from
93c69f3 to
6c0060a
Compare
nastra
reviewed
May 19, 2026
| static Schema schema(Types.StructType unifiedPartitionType, int formatVersion) { | ||
| Preconditions.checkState(!unifiedPartitionType.fields().isEmpty(), "Table must be partitioned"); | ||
| Preconditions.checkState(formatVersion > 0, "Invalid format version: %d", formatVersion); | ||
| Preconditions.checkState(formatVersion > 0, "Invalid format version: %s", formatVersion); |
Contributor
There was a problem hiding this comment.
how did the error msg look like before this fix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guava
Preconditions.checkStatemethod only supports the%splaceholder.This PR replaces invalid patterns and adds a new checkstyle rule similar to the existing
checkArgumentrule.iceberg/.baseline/checkstyle/checkstyle.xml
Lines 85 to 90 in 1802dbf