chore(refactor): add manifest list reader#2541
Open
xanderbailey wants to merge 11 commits into
Open
Conversation
xanderbailey
commented
May 30, 2026
blackmwk
reviewed
Jun 1, 2026
Contributor
blackmwk
left a comment
blackmwk
left a comment
There was a problem hiding this comment.
Thanks @xanderbailey for this pr!
| let results: Vec<_> = | ||
| futures::future::try_join_all(metadata.snapshots().map(|snapshot| async { | ||
| let manifest_list = snapshot.load_manifest_list(io, metadata).await?; | ||
| let manifest_list = ManifestListReader::new(snapshot, io, metadata) |
Contributor
There was a problem hiding this comment.
Why not use table.manifest_list_reader method? This problem with new method is that we will need to do a lot of changes when adding a new parameter.
Contributor
Author
There was a problem hiding this comment.
We don't have access to a table directly in the catalog utils, do you think we should do a broader refactor here?
Contributor
There was a problem hiding this comment.
No, we can, you can take a look at the call site of this method.
Contributor
There was a problem hiding this comment.
Yes, and we should make this method crate private, it should not be called by user directly.
| } | ||
|
|
||
| impl<'a> ManifestListReader<'a> { | ||
| pub(crate) fn new( |
Contributor
There was a problem hiding this comment.
Maybe we can limit the visitilibyt to table module?
xanderbailey
force-pushed
the
xb/manifest-list-reader
branch
from
f0d5779 to
7cb919b
Compare
xanderbailey
force-pushed
the
xb/manifest-list-reader
branch
from
b82caed to
978c244
Compare
xanderbailey
force-pushed
the
xb/manifest-list-reader
branch
from
ac55903 to
0449759
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Refactor required for PR which adds a
ManifestListReaderwhich mirrors the currentManifestListWriter. This will allow us to carry the encryption manager here also in the linked PRWhat changes are included in this PR?
Adds a new public struct
ManifestListReaderwhich carries the things required to read a manifest list. Refactors call-sites to use this new struct and adds a deprecation for the old method.Are these changes tested?