Open
Conversation
gabeiglio
reviewed
Apr 11, 2026
Comment on lines
+651
to
+652
| You can also use this method to check for view existence using 'try catalog.load_view() except NoSuchViewError'. | ||
| Note: This method doesn't scan data stored in the view. |
Contributor
There was a problem hiding this comment.
Nit: I would say we remove these.
| assert actual == expected | ||
|
|
||
|
|
||
| def test_load_view_404(rest_mock: Mocker) -> None: |
Contributor
There was a problem hiding this comment.
Would also add a test that should return a view does not exists when trying to load a table with loadView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is part of #818 and implements the
load_viewmethod for REST catalogs.Are these changes tested?
Unit tests are added for:
Are there any user-facing changes?
This adds the
load_viewmethod for REST catalogs