Skip to content

Document the Open button next to the pipeline or workflow file in transform and action dialogs, fixes #9379 - #9382

Merged
bamaer merged 1 commit into
apache:mainfrom
Adalennis:9379
Nov 8, 2026
Merged

bamaer merged 1 commit into
apache:mainfrom
Adalennis:9379

Conversation

@Adalennis

Copy link
Copy Markdown
Contributor

Fixes #9379

Since #5275, the dialogs that reference a pipeline or workflow have an Open button next to Browse. The option that holds the file now mentions it on the pages of the Pipeline executor, Workflow executor, Simple mapping, Multi mapping, Metadata injection, Kafka consumer and Azure Event Hubs listener transforms, and of the Pipeline, Workflow and Repeat actions:

  • Open opens the file in Hop Gui, or switches to it when it is already open. When the dialog has unsaved changes, Hop first asks whether to save them (ReferencedFileOpener).
  • In the Pipeline executor and Workflow executor, Open is disabled when the file name comes from a field.
  • In Multi mapping the same button is labelled Edit, next to a New button that creates an empty pipeline file. The page uses those names.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@bamaer

bamaer commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Thanks @Adalennis, LGTM. I checked the ten pages against the dialogs on main: they're the ten that use ReferencedFileOpener, and the save prompt, the disabled button in the executors and the Multi mapping Edit/New labels match the code. All ten pages render fine with asciidoctor. Code and docs reviewed, Hop Gui not run.

Minor, optional: in Multi mapping, New first asks where to save the file, so something like "New asks for a file name, creates an empty pipeline there and uses it" would be a bit more precise.

@bamaer
bamaer merged commit ecda596 into apache:main Nov 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Document the Open button next to the pipeline or workflow file in transform and action dialogs

2 participants