HBASE-30100 Fix misleading Javadoc for Table.batch about null in results array#8109
Merged
junegunn merged 1 commit intoapache:masterfrom Apr 22, 2026
Merged
HBASE-30100 Fix misleading Javadoc for Table.batch about null in results array#8109junegunn merged 1 commit intoapache:masterfrom
junegunn merged 1 commit intoapache:masterfrom
Conversation
…lts array The Javadoc claimed a null in the result array means the action failed even after retries. This has been wrong since HBASE-6295 (0.96.0): per-action failures now store the Throwable in the slot, not null. The only remaining case where null appears is when the batch is rejected before dispatch by synchronous input validation in RawAsyncTableImpl.batch (e.g., IllegalArgumentException from validateMutation), in which case all slots will be null and no retries are attempted.
PDavid
approved these changes
Apr 21, 2026
Contributor
PDavid
left a comment
PDavid
left a comment
There was a problem hiding this comment.
Many thanks for the correction. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-30100