GUACAMOLE-2296: Broadcast guacLoginUpdated event on token renewal#1225
Open
arulrajnet wants to merge 1 commit into
Open
GUACAMOLE-2296: Broadcast guacLoginUpdated event on token renewal#1225arulrajnet wants to merge 1 commit into
arulrajnet wants to merge 1 commit into
Conversation
When a server re-issues the same authentication token (token renewal/extension scenario), emit the new 'guacLoginUpdated' event to notify listeners that an existing session has been renewed. This distinguishes token renewal from new login events and enables downstream applications to detect session re-authentication. Changes: - Add guacLoginUpdated broadcast in authenticate() when token remains unchanged - Document new event in service javadoc - Update comment to reflect event emission behavior
Contributor
|
@arulrajnet I'm not sure I understand the point of just adding this definition - it doesn't look like it actually gets used or consumed anywhere?? The other events that are broadcast - for example, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a server re-issues the same authentication token (token renewal/extension scenario), emit the new 'guacLoginUpdated' event to notify listeners that an existing session has been renewed. This distinguishes token renewal from new login events and enables downstream applications to detect session re-authentication.
Changes: