GUACAMOLE-2034 : fixed a few typos, missing translation and formatting issues in french fr.json by YAGA29 · Pull Request #1062 · apache/guacamole-client

YAGA29 · 2025-02-22T14:58:00Z

Fixed a few typos, missing translation and formatting issues in french fr.json
Harmonization with en.json file

Fixed a few typos and formatting. Harmonization with en.json file

necouchman

@YAGA29 Thank you for submitting this PR and helping out with these translations. I've noted a few specifics, but, generally:

You don't need to add items to the translation that aren't actually being translated, as Guacamole will automatically pull from the default (English) translation.
I'm unsure about the addition of the space before every colon (:). As we don't do this in other translations, is there some specific reason to do it in the French translation?

Also, please re-base this PR against the apache:patch branch - the changes for 1.6.0 are already pretty well fixed, and this will not go into that release.

necouchman · 2025-02-25T12:24:23Z

+        "NAME"    : "Apache Guacamole",
+        "VERSION" : "${project.version}",
+


Please do not put these lines in here - the translations will inherit from the default (English) translation, and this is both not required and will cause problems.

Ok thanks, I'll delete these lines in fr.json file.

necouchman · 2025-02-25T12:29:35Z

+        "FIELD_HEADER_PASSWORD"       : "Mot de passe : ",
+        "FIELD_HEADER_PASSWORD_AGAIN" : "Répéter mot de passe : ",
+        "FIELD_HEADER_RECORDING_WRITE_EXISTING"  : "Autoriser l'écriture dans le fichier d'enregistrement existant : ",
+        "FIELD_HEADER_TYPESCRIPT_WRITE_EXISTING" : "Autoriser l'écriture dans le fichier TypeScript existant : ",


What's the reason for the additional space before the : in these translations?

In French, the rule is to add a non-breaking space before colon and a space after colon. https://fr.wikipedia.org/wiki/Ponctuation

I don't know if we can use a nbsp in the translation file.

But that's just a small detail. Please let me know what you prefer, I can remove the space before every colon.

necouchman · 2025-02-25T12:31:55Z

+        "FIELD_OPTION_QUALITY_LEVEL_0"     : "0",
+        "FIELD_OPTION_QUALITY_LEVEL_1"     : "1",
+        "FIELD_OPTION_QUALITY_LEVEL_2"     : "2",
+        "FIELD_OPTION_QUALITY_LEVEL_3"     : "3",
+        "FIELD_OPTION_QUALITY_LEVEL_4"     : "4",
+        "FIELD_OPTION_QUALITY_LEVEL_5"     : "5",
+        "FIELD_OPTION_QUALITY_LEVEL_6"     : "6",
+        "FIELD_OPTION_QUALITY_LEVEL_7"     : "7",
+        "FIELD_OPTION_QUALITY_LEVEL_8"     : "8",
+        "FIELD_OPTION_QUALITY_LEVEL_9"     : "9",
+        "FIELD_OPTION_QUALITY_LEVEL_EMPTY" : "",
+


There is no need to add these to the translation file - it will inherit from the English translation, if no translation is being done.

Ok thanks, I'll delete these lines in fr.json file.

necouchman · 2025-02-25T12:32:16Z

+        "FIELD_OPTION_COMPRESS_LEVEL_0"     : "0",
+        "FIELD_OPTION_COMPRESS_LEVEL_1"     : "1",
+        "FIELD_OPTION_COMPRESS_LEVEL_2"     : "2",
+        "FIELD_OPTION_COMPRESS_LEVEL_3"     : "3",
+        "FIELD_OPTION_COMPRESS_LEVEL_4"     : "4",
+        "FIELD_OPTION_COMPRESS_LEVEL_5"     : "5",
+        "FIELD_OPTION_COMPRESS_LEVEL_6"     : "6",
+        "FIELD_OPTION_COMPRESS_LEVEL_7"     : "7",
+        "FIELD_OPTION_COMPRESS_LEVEL_8"     : "8",
+        "FIELD_OPTION_COMPRESS_LEVEL_9"     : "9",
+        "FIELD_OPTION_COMPRESS_LEVEL_EMPTY" : "",
+


There is no need to add items that are not being translated.

Ok thanks, I'll delete these lines in fr.json file.

YAGA29 · 2025-02-25T20:52:41Z

@YAGA29 Thank you for submitting this PR and helping out with these translations. I've noted a few specifics, but, generally:

@necouchman Thank you for your feedback. My responses below.

You don't need to add items to the translation that aren't actually being translated, as Guacamole will automatically pull from the default (English) translation.

Ok perfect, I'll remove these items.

I'm unsure about the addition of the space before every colon (:). As we don't do this in other translations, is there some specific reason to do it in the French translation?

In French, the rule is to add a non-breaking space before colon and a space after colon. https://fr.wikipedia.org/wiki/Ponctuation

I don't know if we can use a nbsp in the translation file.

But that's just a small detail. Please let me know what you prefer, I can remove the space before every colon.

Also, please re-base this PR against the apache:patch branch - the changes for 1.6.0 are already pretty well fixed, and this will not go into that release.

Ok perfect, I'll do that by the end of the week.

mike-jumper · 2025-03-04T10:59:52Z

I don't know if we can use a nbsp in the translation file.

If non-breaking spaces are needed, I think you will need to use Unicode characters to represent them. In Unicode, the character for a non-breaking space is U+00A0, which would be \u00a0 in a JSON string.

YAGA29 · 2025-03-23T17:33:43Z

@necouchman

Hi Nick,

I have taken into account all your comments and re-based this PR against the apache:patch branch as requested.
with the title "GUACAMOLE-2034 : Fix few typos, missing translation and formatting issue…"

Regards,

YAGA29 · 2025-03-23T17:50:28Z

I don't know if we can use a nbsp in the translation file.

If non-breaking spaces are needed, I think you will need to use Unicode characters to represent them. In Unicode, the character for a non-breaking space is U+00A0, which would be \u00a0 in a JSON string.

Hi Mike,

Sorry for not responding sooner. Thanks for your input but unfortunately \u00a0 in a JSON translation file display &NBSP; in the webpage.

Given that the rules before the colon (:) are slightly different between Swiss French, Canadian French, and French, I have used a compromise with a \u202F (Narrow No-Break Space) that displays correctly.

I have corrected other typos and, as requested by Nick, re-based this PR against the apache:patch branch with the title "GUACAMOLE-2034 : Fix few typos, missing translation and formatting issue…".

Regards

necouchman · 2025-09-22T18:47:29Z

@mike-jumper Can you re-open this one?

mike-jumper · 2025-09-22T21:38:21Z

Yep, and I'll check around for others (though if you know of 'em offhand, please ping me). The process should be just briefly recreating the staging/1.6.0 branch so GitHub will let me reopen and change the merge base.

necouchman · 2025-09-27T16:43:25Z

@YAGA29 In addition to continuing to work through the items @mike-jumper was pointing out, this now has a conflict that must be resolved prior to merge.

adb014 · 2026-06-01T12:47:27Z

I would like to see these translations in a future version of Guacamole. As the original authors gone AWOL, could I rebase this PR, any any other missing translations ? However I don't see how to do that without generating a new PR

adb014 · 2026-06-19T18:32:39Z

@necouchman As #1220 is merged that includes this commit this PR can also be closed

necouchman · 2026-06-19T20:07:23Z

Closed by #1220.

Update fr.json

976bb5f

Fixed a few typos and formatting. Harmonization with en.json file

necouchman requested changes Feb 25, 2025

View reviewed changes

mike-jumper deleted the branch apache:patch June 23, 2025 01:18

mike-jumper closed this Jun 23, 2025

mike-jumper reopened this Sep 22, 2025

mike-jumper changed the base branch from staging/1.6.0 to patch September 22, 2025 23:27

adb014 mentioned this pull request Jun 1, 2026

GUACAMOLE-2034: Update fr.json (rebase and complete) #1217

Closed

adb014 mentioned this pull request Jun 18, 2026

GUACAMOLE-2034: Update fr.json (rebase and complete) #1220

Merged

necouchman closed this Jun 19, 2026

		"NAME" : "Apache Guacamole",
		"VERSION" : "${project.version}",

Uh oh!

Conversation

YAGA29 commented Feb 22, 2025

Uh oh!

necouchman left a comment

Choose a reason for hiding this comment

Uh oh!

necouchman Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

YAGA29 Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

necouchman Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

YAGA29 Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

necouchman Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

YAGA29 Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

necouchman Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

YAGA29 Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YAGA29 commented Feb 25, 2025

Uh oh!

mike-jumper commented Mar 4, 2025

Uh oh!

YAGA29 commented Mar 23, 2025

Uh oh!

YAGA29 commented Mar 23, 2025

Uh oh!

necouchman commented Sep 22, 2025

Uh oh!

mike-jumper commented Sep 22, 2025

Uh oh!

necouchman commented Sep 27, 2025

Uh oh!

adb014 commented Jun 1, 2026

Uh oh!

adb014 commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

necouchman commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

YAGA29 Feb 25, 2025 •

edited

Loading

adb014 commented Jun 19, 2026 •

edited

Loading