GROOVY-12022: replace indy code for array access in static compilation#2546
Open
blackdrag wants to merge 2 commits into
Open
GROOVY-12022: replace indy code for array access in static compilation#2546blackdrag wants to merge 2 commits into
blackdrag wants to merge 2 commits into
Conversation
…n mode with existing code in BytecodeInterface8 and deprecate now surplus IndyStaticTypesMultiTypeDispatcher. Performance wise there is no gain to use indy here and it simplifies code paths and JIT work
… old invokedynamic instruction is no longer valid
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2546 +/- ##
==================================================
- Coverage 68.1956% 68.1536% -0.0420%
- Complexity 32936 32966 +30
==================================================
Files 1503 1504 +1
Lines 125706 125782 +76
Branches 22743 22759 +16
==================================================
- Hits 85726 85725 -1
- Misses 32422 32511 +89
+ Partials 7558 7546 -12
🚀 New features to boost your workflow:
|
|
✅ All tests passed ✅🏷️ Commit: b2cb3f2 Learn more about TestLens at testlens.app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace indy code for array access in static compilation mode with existing code in BytecodeInterface8 and deprecate now surplus IndyStaticTypesMultiTypeDispatcher. Performance wise there is no gain to use indy here and it simplifies code paths and JIT work