Skip to content

GROOVY-12021: Add DO macro for monadic comprehensions over Optional/S…#2545

Open
paulk-asert wants to merge 1 commit into
apache:masterfrom
paulk-asert:groovy12021
Open

GROOVY-12021: Add DO macro for monadic comprehensions over Optional/S…#2545
paulk-asert wants to merge 1 commit into
apache:masterfrom
paulk-asert:groovy12021

Conversation

@paulk-asert
Copy link
Copy Markdown
Contributor

…tream/Awaitable and @monadic types

This comment was marked as low quality.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2026

Codecov Report

❌ Patch coverage is 68.82353% with 106 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.1855%. Comparing base (7865789) to head (f4fc5ae).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...n/groovy/groovy/typecheckers/MonadicChecker.groovy 57.1429% 9 Missing and 30 partials ⚠️
...ovy/groovy/typecheckers/MonadicShapeChecker.groovy 60.0000% 14 Missing and 24 partials ⚠️
...java/org/apache/groovy/runtime/Comprehensions.java 70.3704% 4 Missing and 12 partials ⚠️
.../apache/groovy/macrolib/MacroLibGroovyMethods.java 80.9524% 3 Missing and 5 partials ⚠️
.../apache/groovy/runtime/MonadicCarrierRegistry.java 91.3793% 2 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2545        +/-   ##
==================================================
- Coverage     68.1886%   68.1855%   -0.0031%     
- Complexity      32960      33084       +124     
==================================================
  Files            1504       1508         +4     
  Lines          125785     126125       +340     
  Branches        22760      22878       +118     
==================================================
+ Hits            85771      85999       +228     
- Misses          32453      32488        +35     
- Partials         7561       7638        +77     
Files with missing lines Coverage Δ
.../apache/groovy/runtime/MonadicCarrierRegistry.java 91.3793% <91.3793%> (ø)
.../apache/groovy/macrolib/MacroLibGroovyMethods.java 79.0323% <80.9524%> (+4.0323%) ⬆️
...java/org/apache/groovy/runtime/Comprehensions.java 70.3704% <70.3704%> (ø)
...ovy/groovy/typecheckers/MonadicShapeChecker.groovy 60.0000% <60.0000%> (ø)
...n/groovy/groovy/typecheckers/MonadicChecker.groovy 57.1429% <57.1429%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This comment was marked as low quality.

@paulk-asert paulk-asert marked this pull request as draft May 19, 2026 08:40
@paulk-asert paulk-asert marked this pull request as ready for review May 19, 2026 08:40
@paulk-asert paulk-asert requested a review from Copilot May 19, 2026 08:40

This comment was marked as low quality.

@paulk-asert paulk-asert marked this pull request as draft May 19, 2026 22:52
@paulk-asert paulk-asert marked this pull request as ready for review May 19, 2026 22:53
@paulk-asert paulk-asert requested a review from Copilot May 19, 2026 22:53
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

Comment thread src/main/java/org/apache/groovy/runtime/Comprehensions.java
@testlens-app
Copy link
Copy Markdown

testlens-app Bot commented May 20, 2026

✅ All tests passed ✅

🏷️ Commit: f4fc5ae
▶️ Tests: 99769 executed
⚪️ Checks: 28/28 completed


Learn more about TestLens at testlens.app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants