Repository navigation
[FLINK-40912][Connectors/Kafka] Close the exactly-once writer's AdminClient - #332
Merged
snuyanzin merged 1 commit intoOct 8, 2026
Merged
Conversation
Savonitar
force-pushed
the
fix/flink-40912-close-admin-client
branch
3 times, most recently
from
October 5, 2026 16:32
e11b610 to
c2ed2fe
Compare
Savonitar
marked this pull request as ready for review
October 5, 2026 16:36
Efrat19
reviewed
Oct 6, 2026
Efrat19
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing this leak! Mostly LGTM
Savonitar
force-pushed
the
fix/flink-40912-close-admin-client
branch
from
October 7, 2026 15:59
f4abc3e to
413ff1c
Compare
Efrat19
reviewed
Oct 8, 2026
Efrat19
approved these changes
Oct 8, 2026
…Client Close the lazily created admin client after the existing writer cleanup so POOLING writer restarts do not leak its network thread and resources. Verify that POOLING releases its admin client and INCREMENTING closes without creating one. Generated-by: Codex (GPT-6)
Savonitar
force-pushed
the
fix/flink-40912-close-admin-client
branch
from
October 8, 2026 12:52
0327bee to
51623cf
Compare
snuyanzin
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix FLINK-40912:
ExactlyOnceKafkaWritercreates an admin client for POOLING transaction cleanup but never closes it. Each writer restart can leak its network thread and associated resources.Brief change log
getOrCreateAdminClient().Verifying this change
ExactlyOnceKafkaWriterTest,ExactlyOnceKafkaWriterITCase, and the two architecture test classes pass. Checkstyle and Spotless pass; frozen ArchUnit violation stores are unchanged.Does this pull request potentially affect one of the following parts:
Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-6)