Skip to content

feat(core): use current device pixel ratio when resize #21489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Justin-ZS wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(core): use current device pixel ratio when resize #21489

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6f8218
feat(drp): use current dpr when resize
Justin-ZS Jan 22, 2026
a29afe9
fix: get default dpr in zrender
Justin-ZS Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/core/echarts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ export interface SetOptionOpts {
export interface ResizeOpts {
width?: number | 'auto', // Can be 'auto' (the same as null/undefined)
height?: number | 'auto', // Can be 'auto' (the same as null/undefined)
devicePixelRatio?: number,
animation?: AnimationOption
silent?: boolean // by default false.
};
Expand Down Expand Up @@ -1364,7 +1365,14 @@ class ECharts extends Eventful<ECEventDefinition> {
return;
}

this._zr.resize(opts);
// Default to use window.devicePixelRatio to handle browser zoom changes.
const zrResizeOpts = opts ? extend({}, opts) : {};
if (zrResizeOpts.devicePixelRatio == null && env.hasGlobalWindow) {
/* eslint-disable-next-line */
zrResizeOpts.devicePixelRatio = window.devicePixelRatio;
}

this._zr.resize(zrResizeOpts);
Copy link
Copy Markdown
Member

@plainheart plainheart Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the devicePixelRatio is now fetched and used by zrender, I think we can move this logic to zrender. Here, we only need to pass the user-defined resize options.

Copy link
Copy Markdown
Contributor Author

@Justin-ZS Justin-ZS Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. The devicePixelRatio is fetched in zrender now.


const ecModel = this._model;

Expand Down