Skip to content

fix(bar): fix borderColor hides bar color with large data #20465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ovilia merged 10 commits into from
Nov 14, 2024
Merged

fix(bar): fix borderColor hides bar color with large data #20465

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
04bfaf9
fix(BarView): borderColor hides bar color with large data. close #18185
DevitX Oct 30, 2024
c66c503
test(candlestick): add test case for candlestick volume bars with bor…
DevitX Oct 30, 2024
904ce49
fix(Bar): updated with reviewed changes
DevitX Nov 6, 2024
4d1a570
test(bar): changed test case for dense bars with border and fill color
DevitX Nov 6, 2024
aea7c6f
Merge branch 'apache:master' into fix-18185
DevitX Nov 6, 2024
4d452fd
test(bar): rename file and updated title
DevitX Nov 6, 2024
9e4ff9f
test(bar): fix path
DevitX Nov 6, 2024
965a7f3
test(bar): changed path of test
DevitX Nov 6, 2024
480b7f9
Merge branch 'apache:master' into fix-18185
DevitX Nov 12, 2024
47e5928
fix(Bar): revert the strokeFirst to stroke null following the reviewe…
DevitX Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/chart/bar/BarView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,7 +1176,8 @@ function createLarge(
el.barWidth = barWidth;
group.add(el);
el.useStyle(data.getVisual('style'));

// Reset stroke color
el.style.stroke = null;
Comment thread
DevitX marked this conversation as resolved.
// Enable tooltip and user mouse/touch event handlers.
getECData(el).seriesIndex = seriesModel.seriesIndex;

Expand Down
356 changes: 356 additions & 0 deletions test/candlestick-large-bar-border-color
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.