-
Notifications
You must be signed in to change notification settings - Fork 19.8k
Aria omit columns #20038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aria omit columns #20038
Changes from 4 commits
ad1d487
64b51e9
5ad8f6e
a67fd83
99d9731
77580e9
1b630cb
bcd1a81
9cb5d9a
94fd435
da33a83
34b4eed
7b5e85b
d76ce4e
f2c165d
5a1ad78
1a456fa
c74c28a
5bcac1c
c630017
0ab51ee
212ee25
01c2e6e
b3eac27
1577bce
1a06ff8
50339df
9a65f9d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -202,7 +202,11 @@ export default function ariaVisual(ecModel: GlobalModel, api: ExtensionAPI) { | |
| seriesType: getSeriesTypeName(seriesModel.subType as SeriesTypes) | ||
| }); | ||
|
|
||
| const data = seriesModel.getData(); | ||
| let data = seriesModel.getData(); | ||
| const columnsToExclude = labelModel.get(['data', 'columnsToExclude']); | ||
| if (columnsToExclude) { | ||
| data = data.filterSelf(idx => !columnsToExclude?.includes(idx)); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will make the elements in the chart not rendered. What we want is only to change the aria-label instead of the original chart.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wanted to do the filtering before the check with What do you think?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What kind of filtering does this PR want to provide? Do you want to hiding some bars or only eliminate some dimensions from aria-label (in which case you shouldn't call
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Only eliminate some dimensions form aria-label. So |
||
| } | ||
| if (data.count() > maxDataCnt) { | ||
| // Show part of data | ||
| const partialLabel = labelModel.get(['data', 'partialData']); | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see other places in the code use
excludeSeriesId, so perhaps here we should useexcludeDataIdinstead.