Skip to content
Closed
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
ad1d487
feat(aria): omit columns
semla Jun 14, 2024
64b51e9
add test for excluding data from aria
semla Jun 15, 2024
5ad8f6e
exclude aria columns directly
semla Jun 15, 2024
a67fd83
Merge branch 'apache:master' into aria-omit-columns
semla Jun 17, 2024
99d9731
Merge branch 'apache:master' into aria-omit-columns
semla Jun 20, 2024
77580e9
fix(aria): filter columns and only aria
semla Jun 20, 2024
1b630cb
test(aria): add test for not modifying graph data
semla Jun 20, 2024
bcd1a81
fix(aria): filter columns, not data items
semla Jun 21, 2024
9cb5d9a
test(aria): update test to realistic use case
semla Jun 21, 2024
94fd435
Merge branch 'apache:master' into aria-omit-columns
semla Jul 15, 2024
da33a83
test(aria): rename test file
semla Jul 16, 2024
34b4eed
fix(legend): fix legend action is not isolated from other legend comp…
plainheart Jul 8, 2024
7b5e85b
test(legend): add a test case for legend action
plainheart Jul 9, 2024
d76ce4e
fix(legend): fix legend item is selected but corresponding series may…
plainheart Jul 11, 2024
f2c165d
fix(legend): remove unused import
plainheart Jul 11, 2024
5a1ad78
fix(legend): remove duplicated type of legend select method name
plainheart Jul 11, 2024
1a456fa
fix(legend): return allSelectedMap rather than selectedMap
plainheart Jul 11, 2024
c74c28a
fix(candlestick): add back missing support for non-normal states sinc…
plainheart Jul 2, 2024
5bcac1c
fix(candlestick): disable emphasis state by default for forward compa…
plainheart Jul 2, 2024
c630017
fix(candelstick): still enable emphasis state by default
plainheart Jul 15, 2024
0ab51ee
perf(line): prebind context of `_changePolyState` function to current…
plainheart Jul 15, 2024
212ee25
feature(axis): add feature to remove SplitLine on specified tick
Jul 4, 2024
01c2e6e
fix(pie): Missing pie chart label display. close #20070
zhangyu-ts Jun 25, 2024
b3eac27
fix(pie): fix some labels may not show #20074
zhangyu-ts Jul 9, 2024
1577bce
chore(deps-dev): bump socket.io-parser in /test/runTest
dependabot[bot] Jul 23, 2024
1a06ff8
fix(axis): ticks overflowing grid area with dataZoom #20185
Ovilia Jul 24, 2024
50339df
perf(aria): use functions from zrender
semla Jul 26, 2024
9a65f9d
test(aria): also test values that should exist
semla Jul 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/util/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1727,7 +1727,8 @@ export interface AriaLabelOption {
separator?: {
middle?: string;
end?: string;
}
},
columnsToExclude?: number[]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see other places in the code use excludeSeriesId, so perhaps here we should use excludeDataId instead.

}
}

Expand Down
3 changes: 2 additions & 1 deletion src/visual/aria.ts
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,10 @@ export default function ariaVisual(ecModel: GlobalModel, api: ExtensionAPI) {

const middleSeparator = labelModel.get(['data', 'separator', 'middle']);
const endSeparator = labelModel.get(['data', 'separator', 'end']);
const columnsToExclude = labelModel.get(['data', 'columnsToExclude']);
const dataLabels = [];
for (let i = 0; i < data.count(); i++) {
if (i < maxDataCnt) {
if (i < maxDataCnt && !columnsToExclude?.includes(i)) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i is the index of data. How can we filter certain dimensions by checking index of data? The current code is more like dataIndexToExclude than columnsToExclude.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, how about bcd1a81 instead?

const name = data.getName(i);
const value = data.getValues(i);
const dataLabel = labelModel.get(['data', name ? 'withName' : 'withoutName']);
Expand Down
151 changes: 151 additions & 0 deletions test/ut/spec/series/aria.test.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.