Skip to content

perf: reducing allocations in copy #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proost merged 1 commit into from
Aug 15, 2026
Merged

perf: reducing allocations in copy #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpc/cpc_sketch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ func (c *CpcSketch) updateWindowed(rowCol int) error {
}

isNovel := false //novel if new coupon
err := error(nil)
var err error
col := rowCol & 63

if col < c.windowOffset { // track the surprising 0's "before" the window
Expand Down
1 change: 0 additions & 1 deletion cpc/pair_table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,6 @@ func (p *pairTable) copy() (*pairTable, error) {
// copy the number of pairs.
newPT.numPairs = p.numPairs
// Deep copy the slots array.
newPT.slotsArr = make([]int, len(p.slotsArr))
copy(newPT.slotsArr, p.slotsArr)
return newPT, nil
}
Expand Down
Loading