Skip to content

Add conserve mode for VPC offerings #12487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 20 commits into from
Mar 16, 2026

Fix load balancer rule VMs from multiple VPC tiers on Conserve mode

8977d3d
Select commit
Loading
Failed to load commit list.
Merged

Add conserve mode for VPC offerings #12487

Fix load balancer rule VMs from multiple VPC tiers on Conserve mode
8977d3d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 13, 2026 in 0s

17.93% (+0.00%) compared to 74af9b9

View this Pull Request on Codecov

17.93% (+0.00%) compared to 74af9b9

Details

Codecov Report

❌ Patch coverage is 35.54217% with 107 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.93%. Comparing base (74af9b9) to head (8977d3d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/com/cloud/network/IpAddressManagerImpl.java 0.00% 26 Missing and 2 partials ⚠️
...loud/network/lb/LoadBalancingRulesManagerImpl.java 63.15% 15 Missing and 6 partials ⚠️
...user/loadbalancer/AssignToLoadBalancerRuleCmd.java 0.00% 15 Missing ⚠️
...e/cloudstack/api/response/VpcOfferingResponse.java 0.00% 6 Missing ⚠️
...main/java/com/cloud/network/vpc/VpcOfferingVO.java 0.00% 6 Missing ⚠️
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java 66.66% 2 Missing and 3 partials ⚠️
...om/cloud/network/firewall/FirewallManagerImpl.java 75.00% 1 Missing and 3 partials ⚠️
...ck/api/command/admin/vpc/CreateVPCOfferingCmd.java 0.00% 3 Missing ⚠️
.../cloudstack/api/response/FirewallRuleResponse.java 0.00% 3 Missing ⚠️
...rg/apache/cloudstack/api/response/VpcResponse.java 0.00% 3 Missing ⚠️
... and 8 more
Additional details and impacted files 
@@            Coverage Diff             @@
##               main   #12487    +/-   ##
==========================================
  Coverage     17.92%   17.93%            
- Complexity    16176    16193    +17     
==========================================
  Files          5949     5949            
  Lines        534058   534212   +154     
  Branches      65301    65330    +29     
==========================================
+ Hits          95742    95793    +51     
- Misses       427560   427653    +93     
- Partials      10756    10766    +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov