Skip to content

Instance lease: Allow deployment of instances with lease duration and leaseexpiry action #10560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 37 commits into from
May 28, 2025

dont use forced: true for StopVmCmd

d5988a5
Select commit
Loading
Failed to load commit list.
Merged

Instance lease: Allow deployment of instances with lease duration and leaseexpiry action #10560

dont use forced: true for StopVmCmd
d5988a5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 23, 2025 in 1s

16.57% (+0.04%) compared to b17808b

View this Pull Request on Codecov

16.57% (+0.04%) compared to b17808b

Details

Codecov Report

Attention: Patch coverage is 55.48654% with 215 lines in your changes missing coverage. Please review.

Project coverage is 16.57%. Comparing base (b17808b) to head (d5988a5).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
...apache/cloudstack/vm/lease/VMLeaseManagerImpl.java 72.89% 43 Missing and 15 partials ⚠️
...ava/com/cloud/api/query/dao/UserVmJoinDaoImpl.java 38.00% 28 Missing and 3 partials ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java 10.71% 25 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 76.82% 13 Missing and 6 partials ⚠️
...apache/cloudstack/api/response/UserVmResponse.java 0.00% 18 Missing ⚠️
...main/java/com/cloud/api/query/vo/UserVmJoinVO.java 0.00% 13 Missing ⚠️
...oudstack/api/response/ServiceOfferingResponse.java 0.00% 12 Missing ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 8 Missing ⚠️
...he/cloudstack/api/command/user/vm/DeployVMCmd.java 0.00% 6 Missing ⚠️
...he/cloudstack/api/command/user/vm/UpdateVMCmd.java 0.00% 6 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #10560      +/-   ##
============================================
+ Coverage     16.52%   16.57%   +0.04%     
- Complexity    13791    13852      +61     
============================================
  Files          5716     5719       +3     
  Lines        506016   506911     +895     
  Branches      61380    61535     +155     
============================================
+ Hits          83617    83998     +381     
- Misses       413037   413507     +470     
- Partials       9362     9406      +44

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov