Feature: Add dest_cidr_list support to egress firewall - #298
Open
elivlo wants to merge 4 commits into
Open
Conversation
Adds the destcidrlist parameter to egress firewall rules, allowing users to restrict the destination of egress traffic. The field is optional and maps to the CloudStack API's destcidrlist parameter. Fixes apache#296
Restructure resourceCloudStackEgressFirewallRead to use a switch on the protocol and extract the repeated CIDR set-building into a single cidrSetFromList helper. The helper returns an empty set for an empty list, restoring the guard against empty Destcidrlist consistently across all branches. Verified with the egress firewall acceptance tests against the cloudstack simulator.
|
@elivlo many thanks! It is :) |
Author
|
@sureshanaparti Any update on this one? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Terraform support for restricting egress firewall rule destinations via a new optional dest_cidr_list attribute, mapping to CloudStack’s destcidrlist API parameter. It also refactors the egress firewall rule read logic to simplify CIDR parsing and protocol handling.
Changes:
- Add
dest_cidr_listtocloudstack_egress_firewallrules and send it viaSetDestcidrlist(...)on rule creation. - Refactor rule-read logic with a shared
cidrSetFromListhelper and a protocol-based switch for clearer flow. - Update the egress firewall resource documentation example/arguments and extend
.gitignore.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| website/docs/r/egress_firewall.html.markdown | Documents dest_cidr_list, updates example usage, and clarifies supported protocols. |
| cloudstack/resource_cloudstack_egress_firewall.go | Implements dest_cidr_list in schema/create/read and refactors CIDR parsing/read flow. |
| .gitignore | Ignores .worktrees/ and .env. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+73
to
+78
| "dest_cidr_list": { | ||
| Type: schema.TypeSet, | ||
| Optional: true, | ||
| Elem: &schema.Schema{Type: schema.TypeString}, | ||
| Set: schema.HashString, | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi :)
This PR adds the optional set
dest_cidr_listtocloudstack_egress_firewallrules to restrict egress traffic destinations, mapping to the CloudStackdestcidrlistAPI parameter. It also refactors the rule-read path for some cleanup.Please keep in mind that I ran the following tests in the cloudstack simulator:
make testacc TESTARGS='-run ^TestAccCloudStackEgressFirewall_'It fixes #296 - @artem-sidorenko Does that fit your needs?
It is a complete implementation of #265