Open
Conversation
…1.1 (#49682) ### Rationale for this change Fixes #49586 `std::multimap::extract(key)` does not guarantee returning the first element when there are duplicate keys. ### What changes are included in this PR? Replace extract(key) with lower_bound(key) plus erase(iterator). `lower_bound` guarantees first matching element, then read `it->second` and then `erase` the node (`extract` is not needed as the node isn't reused here). ### Are these changes tested? Yes, CI jobs are passing. ### Are there any user-facing changes? No. * GitHub Issue: #49586 Authored-by: Tadeja Kadunc <tadeja.kadunc@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Member
Author
|
@github-actions crossbow submit -g verify-rc-source |
github-actions
bot
added
Component: C++
awaiting committer review
Member
Author
|
@github-actions crossbow submit --group packaging |
|
Revision: f9203b3 Submitted crossbow builds: ursacomputing/crossbow @ actions-2d7d725ee5
|
|
Revision: f9203b3 Submitted crossbow builds: ursacomputing/crossbow @ actions-92f6bd0af5
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge this PR.
This PR is being used to test the status of the 24.0.0 release branch on CI and should not be merged.