GH-49677 [Python][C++][Compute] Add search sorted compute kernel#49679
Open
Alex-PLACET wants to merge 8 commits intoapache:mainfrom
Open
GH-49677 [Python][C++][Compute] Add search sorted compute kernel#49679Alex-PLACET wants to merge 8 commits intoapache:mainfrom
Alex-PLACET wants to merge 8 commits intoapache:mainfrom
Conversation
|
|
github-actions
bot
added
Component: C++
Component: Python
Component: Documentation
awaiting review
- Added a new benchmark file `vector_search_sorted_benchmark.cc` to evaluate the performance of the SearchSorted function for various data types including Int64, String, and Binary. - Created a comprehensive test suite in `vector_search_sorted_test.cc` to validate the correctness of SearchSorted across different scenarios, including handling of null values, scalar needles, and run-end encoded arrays. - Ensured that the benchmarks cover both left and right search options, as well as edge cases like empty arrays and arrays with leading/trailing nulls.
…rks for needles with null runs
…tation overview and flow
…lize ranges for leading/trailing null counts
…ensive tests for supported types
Alex-PLACET
force-pushed
the
add_search_sorted_compute_kernel
branch
from
8e09ea3 to
4ec630e
Compare
…xcept to length method
tadeja
reviewed
Apr 8, 2026
Comment on lines
+53
to
+58
| [ | ||
| 0, | ||
| 0, | ||
| 3, | ||
| 5 | ||
| ] |
Contributor
There was a problem hiding this comment.
Suggested change
| [ | |
| 0, | |
| 0, | |
| 3, | |
| 5 | |
| ] | |
| [ | |
| 0, | |
| 0, | |
| 3, | |
| 5 | |
| ] |
@Alex-PLACET just noticing that the elements here require two space chars to be removed. Similarly for the next two example outputs.
github-actions
bot
added
awaiting committer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add the implemenation of the search sorted compute kernel based on the numpy function: https://numpy.org/doc/stable/reference/generated/numpy.searchsorted.html
What changes are included in this PR?
Implementation of the C++ kernel + Python API.
Tests in C++ and Python
Are these changes tested?
Yes
Are there any user-facing changes?
No breaking change
search_sortedkernel for all primitive types and run-end encoded arrays #49677