Skip to content

GH-49252: [GLib] Deprecate Feather features #49673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raulcd merged 1 commit into from
Apr 7, 2026
+12 −5
Merged

GH-49252: [GLib] Deprecate Feather features #49673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion c_glib/arrow-glib/input-stream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ garrow_gio_input_stream_new(GInputStream *gio_input_stream);

#ifndef GARROW_DISABLE_DEPRECATED
GARROW_AVAILABLE_IN_ALL
G_GNUC_DEPRECATED
GARROW_DEPRECATED
GInputStream *
garrow_gio_input_stream_get_raw(GArrowGIOInputStream *input_stream);
#endif
Expand Down
2 changes: 1 addition & 1 deletion c_glib/arrow-glib/output-stream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ garrow_gio_output_stream_new(GOutputStream *gio_output_stream);

#ifndef GARROW_DISABLE_DEPRECATED
GARROW_AVAILABLE_IN_ALL
G_GNUC_DEPRECATED
GARROW_DEPRECATED
GOutputStream *
garrow_gio_output_stream_get_raw(GArrowGIOOutputStream *output_stream);
#endif
Expand Down
11 changes: 8 additions & 3 deletions c_glib/arrow-glib/reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,14 @@ garrow_record_batch_reader_get_schema(GArrowRecordBatchReader *reader);

#ifndef GARROW_DISABLE_DEPRECATED
GARROW_AVAILABLE_IN_ALL
G_GNUC_DEPRECATED_FOR(garrow_record_batch_reader_read_next)
GARROW_DEPRECATED_FOR(garrow_record_batch_reader_read_next)
GArrowRecordBatch *
garrow_record_batch_reader_get_next_record_batch(GArrowRecordBatchReader *reader,
GError **error);
#endif
#ifndef GARROW_DISABLE_DEPRECATED
GARROW_AVAILABLE_IN_ALL
G_GNUC_DEPRECATED_FOR(garrow_record_batch_reader_read_next)
GARROW_DEPRECATED_FOR(garrow_record_batch_reader_read_next)
GArrowRecordBatch *
garrow_record_batch_reader_read_next_record_batch(GArrowRecordBatchReader *reader,
GError **error);
Expand Down Expand Up @@ -153,7 +153,7 @@ garrow_record_batch_file_reader_get_version(GArrowRecordBatchFileReader *reader)

#ifndef GARROW_DISABLE_DEPRECATED
GARROW_AVAILABLE_IN_ALL
G_GNUC_DEPRECATED_FOR(garrow_record_batch_file_reader_read_record_batch)
GARROW_DEPRECATED_FOR(garrow_record_batch_file_reader_read_record_batch)
GArrowRecordBatch *
garrow_record_batch_file_reader_get_record_batch(GArrowRecordBatchFileReader *reader,
guint i,
Expand Down Expand Up @@ -183,25 +183,30 @@ struct _GArrowFeatherFileReaderClass
};

GARROW_AVAILABLE_IN_ALL
GARROW_DEPRECATED_IN_24_0_FOR(garrow_record_batch_file_reader_new)
GArrowFeatherFileReader *
garrow_feather_file_reader_new(GArrowSeekableInputStream *file, GError **error);

GARROW_AVAILABLE_IN_ALL
GARROW_DEPRECATED_IN_24_0
gint
garrow_feather_file_reader_get_version(GArrowFeatherFileReader *reader);

GARROW_AVAILABLE_IN_ALL
GARROW_DEPRECATED_IN_24_0_FOR(garrow_record_batch_reader_read_all)
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GARROW_DEPRECATED_IN_24_0_FOR(garrow_record_batch_reader_read_all) doesn’t look like a valid replacement: garrow_record_batch_reader_read_all() takes a GArrowRecordBatchReader*, but this API works on GArrowFeatherFileReader*, and GArrowRecordBatchFileReader is not a GArrowRecordBatchReader. If there’s no single drop-in replacement, use GARROW_DEPRECATED_IN_24_0 (no _FOR) or reference a concrete, correct alternative flow (e.g., garrow_record_batch_file_reader_new() + reading record batches).

Suggested change
GARROW_DEPRECATED_IN_24_0_FOR(garrow_record_batch_reader_read_all)
GARROW_DEPRECATED_IN_24_0

Copilot uses AI. Check for mistakes.
GArrowTable *
garrow_feather_file_reader_read(GArrowFeatherFileReader *reader, GError **error);

GARROW_AVAILABLE_IN_ALL
GARROW_DEPRECATED_IN_24_0
GArrowTable *
garrow_feather_file_reader_read_indices(GArrowFeatherFileReader *reader,
const gint *indices,
guint n_indices,
GError **error);

GARROW_AVAILABLE_IN_ALL
GARROW_DEPRECATED_IN_24_0
GArrowTable *
garrow_feather_file_reader_read_names(GArrowFeatherFileReader *reader,
const gchar **names,
Expand Down
2 changes: 2 additions & 0 deletions c_glib/arrow-glib/table.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,12 @@ struct _GArrowFeatherWritePropertiesClass
};

GARROW_AVAILABLE_IN_0_17
GARROW_DEPRECATED_IN_24_0_FOR(garrow_write_options_new)
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GARROW_DEPRECATED_IN_24_0_FOR(garrow_write_options_new) is likely misleading here: GArrowFeatherWriteProperties configures Feather write behavior, while GArrowWriteOptions is for Arrow IPC serialization. If there isn’t a 1:1 replacement API, prefer using GARROW_DEPRECATED_IN_24_0 (without _FOR) or point to a closer replacement specific to the intended migration path (e.g., IPC file writer + options).

Suggested change
GARROW_DEPRECATED_IN_24_0_FOR(garrow_write_options_new)
GARROW_DEPRECATED_IN_24_0

Copilot uses AI. Check for mistakes.
GArrowFeatherWriteProperties *
garrow_feather_write_properties_new(void);

GARROW_AVAILABLE_IN_0_17
GARROW_DEPRECATED_IN_24_0_FOR(garrow_record_batch_file_writer_new)
gboolean
garrow_table_write_as_feather(GArrowTable *table,
GArrowOutputStream *sink,
Expand Down
Loading