GH-39600: [R] Add trademark attribution to pkgdown site footer#49332
GH-39600: [R] Add trademark attribution to pkgdown site footer#49332thisisnic merged 4 commits intoapache:mainfrom
Conversation
|
@github-actions crossbow submit preview-docs |
|
|
|
Revision: 5e14191 Submitted crossbow builds: ursacomputing/crossbow @ actions-3bc0f1949a
|
jonkeane
left a comment
There was a problem hiding this comment.
I'm not a huge huge fan of the formatting, at a minimum I wish it had a bit more whitespace between the older version bit and the legal text.
I have some suggestions for making it a separate component which might help some, but we maybe nee do <div style="...">...</div> to make this a little more separate from the current footer.
Alternatively: if it were the full length of the screen slightly above the current footer that might make it stand out a little bit less (in a good way)?
|
Yeah, agreed @jonkeane, let's see if that looks a bit cleaner now |
|
@github-actions crossbow submit preview-docs |
|
Revision: 28d5197 Submitted crossbow builds: ursacomputing/crossbow @ actions-d9ecea3de6
|
| legal: | | ||
| <small>Apache Arrow, Arrow, Apache, the Apache logo, and the Apache Arrow project logo are either registered trademarks or trademarks of The Apache Software Foundation in the United States and other countries.</small> |
There was a problem hiding this comment.
Maybe we could warp this in <div class="pkgdown-footer-notice">...</div> and then do something like this in css:
footer {
display: flex;
flex-wrap: wrap;
}
.pkgdown-footer-left {
flex: 1;
}
.pkgdown-footer-right {
flex: 1;
text-align: right;
}
.pkgdown-footer-notice {
order: -1; /* moves it visually above the other two */
flex-basis: 100%; /* forces it onto its own row */
text-align: center;
margin-bottom: 0.5em;
}
?
|
Thanks for iterating with this. https://s3.amazonaws.com/arrow-data/pr_docs/49332/r/ are the docs I'm looking at. They look good, though our Kapa tag is now overlaying them:
|
Generated-by: Claude
Co-authored-by: Jonathan Keane <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Add bottom padding to the footer so the trademark attribution text is not obscured by the floating Kapa AI widget button. Co-Authored-By: Claude Opus 4.5 <[email protected]>
37f82e8 to
8e3239d
Compare
|
@github-actions crossbow submit preview-docs |
|
Revision: 8e3239d Submitted crossbow builds: ursacomputing/crossbow @ actions-4f1140cf99
|
|
I honeslty forgot what the previous version looked like 😬 But yeah we can merge this or that and maybe make it nicer later? |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit eb6108d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |


Rationale for this change
Per ASF policy, documentation pages should include trademark attribution in the footer. See #39461 for the broader effort.
What changes are included in this PR?
Add Apache trademark attribution text to the R pkgdown site footer.
Are these changes tested?
Documentation only. Can verify by building pkgdown site locally.
Are there any user-facing changes?
Footer now includes trademark text matching the main Arrow website.
This PR was generated by Claude. All outputs were reviewed and confirmed before pushing.