Skip to content

GH-39600: [R] Add trademark attribution to pkgdown site footer#49332

Merged
thisisnic merged 4 commits intoapache:mainfrom
thisisnic:GH-39600-pkgdown-footer
Apr 6, 2026
Merged

GH-39600: [R] Add trademark attribution to pkgdown site footer#49332
thisisnic merged 4 commits intoapache:mainfrom
thisisnic:GH-39600-pkgdown-footer

Conversation

@thisisnic
Copy link
Copy Markdown
Member

Rationale for this change

Per ASF policy, documentation pages should include trademark attribution in the footer. See #39461 for the broader effort.

What changes are included in this PR?

Add Apache trademark attribution text to the R pkgdown site footer.

Are these changes tested?

Documentation only. Can verify by building pkgdown site locally.

Are there any user-facing changes?

Footer now includes trademark text matching the main Arrow website.


This PR was generated by Claude. All outputs were reviewed and confirmed before pushing.

@thisisnic thisisnic requested a review from jonkeane as a code owner February 18, 2026 19:09
@thisisnic
Copy link
Copy Markdown
Member Author

@github-actions crossbow submit preview-docs

@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #39600 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link
Copy Markdown

Revision: 5e14191

Submitted crossbow builds: ursacomputing/crossbow @ actions-3bc0f1949a

Task Status
preview-docs GitHub Actions

@thisisnic
Copy link
Copy Markdown
Member Author

Copy link
Copy Markdown
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge huge fan of the formatting, at a minimum I wish it had a bit more whitespace between the older version bit and the legal text.

I have some suggestions for making it a separate component which might help some, but we maybe nee do <div style="...">...</div> to make this a little more separate from the current footer.

Alternatively: if it were the full length of the screen slightly above the current footer that might make it stand out a little bit less (in a good way)?

Image

@github-actions github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting committer review Awaiting committer review awaiting changes Awaiting changes labels Feb 19, 2026
@thisisnic
Copy link
Copy Markdown
Member Author

Yeah, agreed @jonkeane, let's see if that looks a bit cleaner now

@thisisnic
Copy link
Copy Markdown
Member Author

@github-actions crossbow submit preview-docs

@github-actions
Copy link
Copy Markdown

Revision: 28d5197

Submitted crossbow builds: ursacomputing/crossbow @ actions-d9ecea3de6

Task Status
preview-docs GitHub Actions

Comment on lines +369 to +370
legal: |
<small>Apache Arrow, Arrow, Apache, the Apache logo, and the Apache Arrow project logo are either registered trademarks or trademarks of The Apache Software Foundation in the United States and other countries.</small>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could warp this in <div class="pkgdown-footer-notice">...</div> and then do something like this in css:

footer {
    display: flex;
    flex-wrap: wrap;
  }

  .pkgdown-footer-left {
    flex: 1;
  }

  .pkgdown-footer-right {
    flex: 1;
    text-align: right;
  }

  .pkgdown-footer-notice {
    order: -1;          /* moves it visually above the other two */
    flex-basis: 100%;   /* forces it onto its own row */
    text-align: center;
    margin-bottom: 0.5em;
  }

?

@jonkeane
Copy link
Copy Markdown
Member

Thanks for iterating with this.

https://s3.amazonaws.com/arrow-data/pr_docs/49332/r/ are the docs I'm looking at. They look good, though our Kapa tag is now overlaying them:

image

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Feb 24, 2026
thisisnic and others added 2 commits April 6, 2026 17:38
Co-authored-by: Jonathan Keane <[email protected]>
Add bottom padding to the footer so the trademark attribution text
is not obscured by the floating Kapa AI widget button.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@thisisnic thisisnic force-pushed the GH-39600-pkgdown-footer branch from 37f82e8 to 8e3239d Compare April 6, 2026 16:39
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 6, 2026
@thisisnic
Copy link
Copy Markdown
Member Author

@github-actions crossbow submit preview-docs

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

Revision: 8e3239d

Submitted crossbow builds: ursacomputing/crossbow @ actions-4f1140cf99

Task Status
preview-docs GitHub Actions

@thisisnic
Copy link
Copy Markdown
Member Author

They look good, though our Kapa tag is now overlaying them:

I can't tell if the latest fix is any different to those ones, as the past preview is stale, but it's no worse than the status quo - are you happy if we merge either the most recent one or previous one? The Kapa tag moves when we scroll, so it doesn't always overlap it.

image

@jonkeane
Copy link
Copy Markdown
Member

jonkeane commented Apr 6, 2026

I honeslty forgot what the previous version looked like 😬 But yeah we can merge this or that and maybe make it nicer later?

@thisisnic thisisnic merged commit eb6108d into apache:main Apr 6, 2026
15 checks passed
@thisisnic thisisnic removed the awaiting change review Awaiting change review label Apr 6, 2026
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit eb6108d.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants