Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/scripts/r_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ SCRIPT="as_cran <- !identical(tolower(Sys.getenv('NOT_CRAN')), 'true')
build_args <- '--no-build-vignettes'
}

if (!as_cran && requireNamespace('reticulate', quietly = TRUE) && reticulate::py_module_available('pyarrow')) {
if (!as_cran && (requireNamespace('reticulate', quietly = TRUE)) && reticulate::py_module_available('pyarrow')) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the added parentheses here, they shouldn't make a difference.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...they don't - I tried it locally before/after, and whatever was invoking a Python module install must have succeeded when I ran the "before" version, and so when I ran it again "after", I conflated the change in the environment (and thus no console output) with the code change working.

message('Running flight demo server for tests.')
pid_flight <- sys::exec_background(
'python',
Expand Down
Loading