Skip to content

fix(go/adbc/drivermgr): adjust ingest helper to set target before BindStream #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arnoldwakim wants to merge 3 commits into
base: main
Choose a base branch
from
+204 −52
Open

fix(go/adbc/drivermgr): adjust ingest helper to set target before BindStream #4308

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cacbac
fix(go/adbc/drivermgr): adjust ingest helper to set target before Bin…
awakim May 9, 2026
0cd718e
fix: accept deferred ingest binds and add guard tests
awakim May 14, 2026
3c38988
refactor: deduplicate bind handling for prepared and bulk statements
awakim May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions go/adbc/ext.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,19 +100,19 @@ func IngestStream(ctx context.Context, cnxn Connection, reader array.RecordReade
err = errors.Join(err, stmt.Close())
}()

// Bind the record batch stream
if err = stmt.BindStream(ctx, reader); err != nil {
return -1, fmt.Errorf("error during ingestion: BindStream: %w", err)
}

// Set required options
// Set required options before binding
if err = stmt.SetOption(OptionKeyIngestTargetTable, targetTable); err != nil {
return -1, fmt.Errorf("error during ingestion: SetOption(target_table=%s): %w", targetTable, err)
}
if err = stmt.SetOption(OptionKeyIngestMode, ingestMode); err != nil {
return -1, fmt.Errorf("error during ingestion: SetOption(mode=%s): %w", ingestMode, err)
}

// Bind the record batch stream
if err = stmt.BindStream(ctx, reader); err != nil {
return -1, fmt.Errorf("error during ingestion: BindStream: %w", err)
}

// Set other options if provided
if opt.Catalog != "" {
if err = stmt.SetOption(OptionValueIngestTargetCatalog, opt.Catalog); err != nil {
Expand Down Expand Up @@ -167,19 +167,19 @@ func IngestStreamContext(ctx context.Context, cnxn ConnectionWithContext, reader
err = errors.Join(err, stmt.Close(ctx))
}()

// Bind the record batch stream
if err = stmt.BindStream(ctx, reader); err != nil {
return -1, fmt.Errorf("error during ingestion: BindStream: %w", err)
}

// Set required options
// Set required options before binding (some drivers require target first)
if err = stmt.SetOption(ctx, OptionKeyIngestTargetTable, targetTable); err != nil {
return -1, fmt.Errorf("error during ingestion: SetOption(target_table=%s): %w", targetTable, err)
}
if err = stmt.SetOption(ctx, OptionKeyIngestMode, ingestMode); err != nil {
return -1, fmt.Errorf("error during ingestion: SetOption(mode=%s): %w", ingestMode, err)
}

// Bind the record batch stream
if err = stmt.BindStream(ctx, reader); err != nil {
return -1, fmt.Errorf("error during ingestion: BindStream: %w", err)
}

// Set other options if provided
if opt.Catalog != "" {
if err = stmt.SetOption(ctx, OptionValueIngestTargetCatalog, opt.Catalog); err != nil {
Expand Down
Loading