add helper functions moveToCenterOfElement and moveToCenterOfBounds#83
Open
Illyism wants to merge 1 commit into
Open
add helper functions moveToCenterOfElement and moveToCenterOfBounds#83Illyism wants to merge 1 commit into
Illyism wants to merge 1 commit into
Conversation
|
@anvaka This is very helpful. Any chance it can be merged? |
anvaka
reviewed
Sep 2, 2020
Comment on lines
+754
to
+755
| const centerX = -elemBounds.left + (((containerBounds.width / 2) - (elemBounds.width / 2))) | ||
| const centerY = -elemBounds.top + (((containerBounds.height / 2) - (elemBounds.height / 2)) + containerBounds.top) |
Owner
There was a problem hiding this comment.
I'm not sure I understand this math can you please help?
😊
| * @param {Number} yOffset offset y pixels from center vertically | ||
| */ | ||
| function moveToCenterOfElement(element, xOffset = 0, yOffset = 0) { | ||
| const bounds = element.getBoundingClientRect() |
Owner
There was a problem hiding this comment.
is element part of the nested tree?
Note: panzoom works not only with dom elements, but also with canvas/svg/webgl - having element passed directly like this would likely make the API less generic. Ideal solution would delegate this logic into domController or svgController
Also note: panzoom uses older version of ES language. Having consts, destructuring, default values would break the minifier
|
@anvaka I need this too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moveToCenterOfBounds is useful to have separately so you can pass just the bounding box around. Or make your own one without having to use HTML, eg
moveToCenterOfBounds({ left: 0, top: 0, width: 100, height: 100 })