fix: 🐛 解决v1版本中连线vertices工具removeRedundancies设置为false时,拖动连线无法加入历史队列、mouseup事件无法冒泡到连线的问题#4873
Open
linkun-wang wants to merge 4 commits intoantvis:v1from
Open
fix: 🐛 解决v1版本中连线vertices工具removeRedundancies设置为false时,拖动连线无法加入历史队列、mouseup事件无法冒泡到连线的问题#4873linkun-wang wants to merge 4 commits intoantvis:v1from
linkun-wang wants to merge 4 commits intoantvis:v1from
Conversation
Contributor
Author
|
@NewByVector @lxfu1 大佬帮忙看下check流水线的问题,看起来有些报错需要项目管理员才能解决 |
Member
|
这还是 v1 的代码,勇士啊,来看看 master 上有类似的问题吗? |
Contributor
Author
看了下master的代码,应该没有历史队列的问题,但是removeRedundancies为false时,mouseup无法冒泡到edge的问题应该还是存在的。这两天我抽空在本地跑下master的代码再提个pr吧。话说v1的不管了吗?😔😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #4869 :解决连线vertices工具removeRedundancies设置为false时,拖动连线无法加入历史队列、mouseup事件无法冒泡到连线的问题;补充了examples中历史队列&连线vertices工具共同使用的示例场景
Motivation and Context
#4869 :1.x版本中的连线vertices工具,如果配置removeRedundancies为false,则拖动路径点改变连线走向无法加入历史队列;且mouseup事件无法冒泡到连线上(即使设置了stopPropagation为false)
Types of changes
Self Check before Merge