Skip to content

ci: replace manual protoc install with arduino/setup-protoc action #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paikend wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −38
Open

ci: replace manual protoc install with arduino/setup-protoc action #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 21 additions & 38 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@ on:
env:
CARGO_TERM_COLOR: always
RUSTFLAGS: -Dwarnings
# Ubuntu's apt protobuf-compiler is too old (v21.x) to recognize the
# `edition = "2023"` proto syntax used by some examples. Pull a recent
# protoc directly from the GitHub release.
# Pinned protoc version for proto edition="2023" compatibility.
# Installed via arduino/setup-protoc, which caches across runs.
PROTOC_VERSION: "33.5"

jobs:
Expand All @@ -23,11 +22,9 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- name: Install protoc
run: |
curl -fsSL "https://github.com/protocolbuffers/protobuf/releases/download/v${PROTOC_VERSION}/protoc-${PROTOC_VERSION}-linux-x86_64.zip" -o /tmp/protoc.zip
sudo unzip -o /tmp/protoc.zip -d /usr/local
protoc --version
- uses: arduino/setup-protoc@v3
with:
version: ${{ env.PROTOC_VERSION }}
- run: cargo check --workspace --all-features --all-targets

msrv-check:
Expand All @@ -40,11 +37,9 @@ jobs:
with:
toolchain: '1.88'
- uses: Swatinem/rust-cache@v2
- name: Install protoc
run: |
curl -fsSL "https://github.com/protocolbuffers/protobuf/releases/download/v${PROTOC_VERSION}/protoc-${PROTOC_VERSION}-linux-x86_64.zip" -o /tmp/protoc.zip
sudo unzip -o /tmp/protoc.zip -d /usr/local
protoc --version
- uses: arduino/setup-protoc@v3
with:
version: ${{ env.PROTOC_VERSION }}
- run: cargo check --workspace --all-features --all-targets

test:
Expand All @@ -55,11 +50,9 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- name: Install protoc
run: |
curl -fsSL "https://github.com/protocolbuffers/protobuf/releases/download/v${PROTOC_VERSION}/protoc-${PROTOC_VERSION}-linux-x86_64.zip" -o /tmp/protoc.zip
sudo unzip -o /tmp/protoc.zip -d /usr/local
protoc --version
- uses: arduino/setup-protoc@v3
with:
version: ${{ env.PROTOC_VERSION }}
- run: cargo test --workspace --all-features

clippy:
Expand All @@ -72,11 +65,9 @@ jobs:
with:
components: clippy
- uses: Swatinem/rust-cache@v2
- name: Install protoc
run: |
curl -fsSL "https://github.com/protocolbuffers/protobuf/releases/download/v${PROTOC_VERSION}/protoc-${PROTOC_VERSION}-linux-x86_64.zip" -o /tmp/protoc.zip
sudo unzip -o /tmp/protoc.zip -d /usr/local
protoc --version
- uses: arduino/setup-protoc@v3
with:
version: ${{ env.PROTOC_VERSION }}
- run: cargo clippy --workspace --all-features --all-targets -- -D warnings

fmt:
Expand All @@ -100,11 +91,9 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- name: Install protoc
run: |
curl -fsSL "https://github.com/protocolbuffers/protobuf/releases/download/v${PROTOC_VERSION}/protoc-${PROTOC_VERSION}-linux-x86_64.zip" -o /tmp/protoc.zip
sudo unzip -o /tmp/protoc.zip -d /usr/local
protoc --version
- uses: arduino/setup-protoc@v3
with:
version: ${{ env.PROTOC_VERSION }}
- run: cargo doc --workspace --all-features --no-deps

# Integration test: start server, run client, verify RPCs work end-to-end
Expand All @@ -116,11 +105,7 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- name: Install protoc
run: |
curl -fsSL "https://github.com/protocolbuffers/protobuf/releases/download/v${PROTOC_VERSION}/protoc-${PROTOC_VERSION}-linux-x86_64.zip" -o /tmp/protoc.zip
sudo unzip -o /tmp/protoc.zip -d /usr/local
protoc --version
# No protoc needed: multiservice uses checked-in generated code
- run: ./examples/multiservice/test.sh

# Conformance tests: validate protocol compliance.
Expand Down Expand Up @@ -165,11 +150,9 @@ jobs:
with:
targets: wasm32-unknown-unknown
- uses: Swatinem/rust-cache@v2
- name: Install protoc
run: |
curl -fsSL "https://github.com/protocolbuffers/protobuf/releases/download/v${PROTOC_VERSION}/protoc-${PROTOC_VERSION}-linux-x86_64.zip" -o /tmp/protoc.zip
sudo unzip -o /tmp/protoc.zip -d /usr/local
protoc --version
- uses: arduino/setup-protoc@v3
with:
version: ${{ env.PROTOC_VERSION }}
- run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
- run: cargo check -p connectrpc --no-default-features --target wasm32-unknown-unknown
- run: cargo check -p connectrpc --no-default-features --features gzip --target wasm32-unknown-unknown
Expand Down