[Backport 1.0] fix(hgraph): tune from available fp32 codes - #2475
[Backport 1.0] fix(hgraph): tune from available fp32 codes#2475jac0626 wants to merge 2 commits into
Conversation
Select raw, precise FP32, or base FP32 codes as the Tune rebuild source, while allowing no-rebuild transitions without a source. Signed-off-by: jac0626 <jac0626@users.noreply.github.com> Assisted-by: Codex:gpt-5
Require Tune sources to cover the current internal ID range and rebuild precise codes whose serialized payload was omitted. Signed-off-by: jac0626 <jac0626@users.noreply.github.com> Assisted-by: Codex:gpt-5
|
/label S-waiting-on-review |
|
Automated pull request review completed. Review effort: No actionable inline findings were found. |
There was a problem hiding this comment.
Code Review
This pull request refactors HGraph::Tune to improve thread safety, parameter validation, and resource management during index tuning, and adds comprehensive unit tests to verify tuning behavior. The review feedback suggests performing defensive parameter validation at the beginning of the function, casting signed counts to prevent compiler warnings, and refactoring the vector decoding helper to use an RAII scope guard for exception safety and check for decoding failures.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
vsag-bot
left a comment
There was a problem hiding this comment.
Automated inline review completed.
Review effort: medium (210 changed lines across 2 files).
No actionable inline findings were found.
Reviewed commit 0007698.
Summary
Backport #2466 to the
1.0branch.or base FP32 codes instead of relying only on
store_raw_vector.ignore_reorderserialization.and concurrency regression coverage.
Fixes: #2465
Validation
Compatibility