fix(build): upgrade bundled OpenBLAS to 0.3.24 - #2459
Conversation
Use the first OpenBLAS release with Sapphire Rapids and AMX DYNAMIC_ARCH fixes, and keep offline-build documentation aligned. Signed-off-by: jac0626 <jac0626@users.noreply.github.com> Assisted-by: Codex:GPT-5
|
/label S-waiting-on-review |
Merge Protections🟢 All 3 merge protections satisfied — ready to merge. Show 3 satisfied protections🟢 Require kind label
🟢 Require version label
🟢 Require linked issue for feature/bug PRs
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the OpenBLAS dependency from version 0.3.23 to 0.3.24, updating the offline build documentation (both English and Chinese) and modifying the CMake configuration to fetch the new version. The review feedback highlights two main areas for improvement: first, it is recommended to retain the Aliyun OSS mirror fallback rather than replacing it with SourceForge to ensure reliable builds for users in mainland China; second, the verification hash should be updated to use SHA256 instead of MD5 to mitigate security risks associated with cryptographically broken hash algorithms.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
Upgrades the bundled OpenBLAS source build used by VSAG’s third-party superbuild from 0.3.23 to 0.3.24 to address CI host-dependent failures on AVX-512/AMX runners, and aligns offline-build documentation with the new archive/version.
Changes:
- Bump bundled OpenBLAS download URLs, archive name, and MD5 to 0.3.24.
- Replace the project-cache fallback URL with the OpenBLAS SourceForge mirror.
- Update English and Chinese offline-build docs to reference the 0.3.24 archive.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extern/openblas/openblas.cmake | Updates OpenBLAS source URLs + checksum and the downloaded archive name to 0.3.24 for bundled builds. |
| docs/docs/en/src/development/offline_build.md | Updates offline/mirrored OpenBLAS references (version + example filenames) to 0.3.24. |
| docs/docs/zh/src/development/offline_build.md | Updates offline/mirrored OpenBLAS references (version + example filenames) to 0.3.24. |
|
/retest |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Change Type
Linked Issue
What Changed
OpenBLAS 0.3.24 is the first release documenting the relevant Sapphire Rapids,
Cooper Lake, and AMX
DYNAMIC_ARCHfixes. This avoids the host-dependent 0.3.23build failure seen on GitHub runners that expose AVX-512 and AMX.
Test Evidence
make fmtmake lintmake testmake cov, run tests, and collect coverageTest details:
The GitHub TSAN workflow successfully built bundled OpenBLAS 0.3.24 from source on
an x86 runner with AVX-512 runtime support, then completed the TSAN test suite.
Compatibility Impact
Performance and Concurrency Impact
Documentation Impact
Risk and Rollback
Checklist