Skip to content

fix(build): upgrade bundled OpenBLAS to 0.3.24 - #2459

Open
jac0626 wants to merge 1 commit into
antgroup:mainfrom
jac0626:codex/fix-openblas-avx512
Open

fix(build): upgrade bundled OpenBLAS to 0.3.24#2459
jac0626 wants to merge 1 commit into
antgroup:mainfrom
jac0626:codex/fix-openblas-avx512

Conversation

@jac0626

@jac0626 jac0626 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Change Type

  • Bug fix
  • New feature
  • Improvement/Refactor
  • Documentation
  • CI/Build/Infra

Linked Issue

What Changed

  • Upgrade the bundled OpenBLAS source archive from 0.3.23 to 0.3.24.
  • Replace the unavailable project-cache fallback with the OpenBLAS SourceForge mirror.
  • Update the English and Chinese offline-build documentation to use the new archive.

OpenBLAS 0.3.24 is the first release documenting the relevant Sapphire Rapids,
Cooper Lake, and AMX DYNAMIC_ARCH fixes. This avoids the host-dependent 0.3.23
build failure seen on GitHub runners that expose AVX-512 and AMX.

Test Evidence

  • make fmt
  • make lint
  • make test
  • make cov, run tests, and collect coverage
  • Other (describe below)

Test details:

/usr/bin/bash ./scripts/format/check_format.sh
Using clang-format version 15 (required: 15)
Code formatting completed with clang-format-15

Official OpenBLAS 0.3.24 release asset Content-MD5:
23599a30e4ce887590957d94896789c8

GitHub Actions (`Tsan Build & Test Parallel`):
- `Build with TSAN`: passed in 18m16s
- `Run TSAN Tests`: passed in 29m13s

The GitHub TSAN workflow successfully built bundled OpenBLAS 0.3.24 from source on
an x86 runner with AVX-512 runtime support, then completed the TSAN test suite.

Compatibility Impact

  • API/ABI compatibility: none
  • Behavior changes: bundled builds use OpenBLAS 0.3.24 instead of 0.3.23

Performance and Concurrency Impact

  • Performance impact: none expected; no VSAG runtime code changed
  • Concurrency/thread-safety impact: none

Documentation Impact

  • No docs update needed
  • Updated docs:
    • Other: English and Chinese offline-build guides

Risk and Rollback

  • Risk level: low
  • Rollback plan: revert the dependency version, URLs, checksum, and documentation updates

Checklist

  • I have linked the relevant issue
  • Existing bundled-source CI provides regression coverage
  • I have considered API compatibility impact
  • I have updated docs if behavior/workflow changed
  • My commit messages follow project conventions

Use the first OpenBLAS release with Sapphire Rapids and AMX DYNAMIC_ARCH fixes, and keep offline-build documentation aligned.

Signed-off-by: jac0626 <jac0626@users.noreply.github.com>
Assisted-by: Codex:GPT-5
Copilot AI review requested due to automatic review settings July 17, 2026 03:44
@vsag-bot

vsag-bot commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

/label S-waiting-on-review
/waiting-on reviewer
/request-review @jiaweizone
/request-review @wxyucs
/request-review @inabao
/request-review @LHT129

@jac0626 jac0626 added kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 version/1.1 labels Jul 17, 2026
@mergify

mergify Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 3 merge protections satisfied — ready to merge.

Show 3 satisfied protections

🟢 Require kind label

  • label~=^kind/

🟢 Require version label

  • label~=^version/

🟢 Require linked issue for feature/bug PRs

  • body~=(?im)(?:^|[\s\-\*])(?:close[sd]?|fix(?:e[sd])?|resolve[sd]?)\s*:?\s+(?:#\d+|[\w.\-]+/[\w.\-]+#\d+|https?://github\.com/[\w.\-]+/[\w.\-]+/issues/\d+)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the OpenBLAS dependency from version 0.3.23 to 0.3.24, updating the offline build documentation (both English and Chinese) and modifying the CMake configuration to fetch the new version. The review feedback highlights two main areas for improvement: first, it is recommended to retain the Aliyun OSS mirror fallback rather than replacing it with SourceForge to ensure reliable builds for users in mainland China; second, the verification hash should be updated to use SHA256 instead of MD5 to mitigate security risks associated with cryptographically broken hash algorithms.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread extern/openblas/openblas.cmake
Comment thread extern/openblas/openblas.cmake

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the bundled OpenBLAS source build used by VSAG’s third-party superbuild from 0.3.23 to 0.3.24 to address CI host-dependent failures on AVX-512/AMX runners, and aligns offline-build documentation with the new archive/version.

Changes:

  • Bump bundled OpenBLAS download URLs, archive name, and MD5 to 0.3.24.
  • Replace the project-cache fallback URL with the OpenBLAS SourceForge mirror.
  • Update English and Chinese offline-build docs to reference the 0.3.24 archive.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
extern/openblas/openblas.cmake Updates OpenBLAS source URLs + checksum and the downloaded archive name to 0.3.24 for bundled builds.
docs/docs/en/src/development/offline_build.md Updates offline/mirrored OpenBLAS references (version + example filenames) to 0.3.24.
docs/docs/zh/src/development/offline_build.md Updates offline/mirrored OpenBLAS references (version + example filenames) to 0.3.24.

@jac0626

jac0626 commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator Author

/retest

@jac0626
jac0626 marked this pull request as ready for review July 22, 2026 07:20
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 module/docs module/thirdparty size/M version/1.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug](build): support bundled OpenBLAS builds on AVX-512/AMX runners

4 participants