Migrating the Cumulus provider from NCLU to NVUE.#76
Open
ybettan wants to merge 1 commit into
Open
Conversation
Cumulus Linux 5.x replaced NCLU (`net add/del`) with NVUE (`nv set/unset`)
as the primary CLI. The `nclu` Ansible module used by the existing provider
is deprecated and fails with deserialization errors on ansible-core 2.20+.
This commit updates all Cumulus provider task files to use NVUE commands
via the `raw` module:
- create_vlan: `nv set bridge domain br_default vlan`
- delete_vlan: `nv unset bridge domain br_default vlan`
- conf_access_port: `nv set interface ... bridge domain br_default access`
- conf_trunk_port: `nv set interface ... bridge domain br_default`
- delete_port: `nv unset interface ... bridge domain` + link state down
Additionally, `add_trunk_vlan` and `delete_trunk_vlan` which were previously
unimplemented ("not implimented") are now functional using NVUE.
Tested against Cumulus VX 5.3.0 in a Containerlab environment.
Signed-off-by: Yoni Bettan <yonibettan@gmail.com>
|
Build failed. ❌ ansible-tox-py36 NODE_FAILURE Node(set) request 200-0000113253 failed in 0s |
Author
|
There tests are passing locally: /retest Is this an infra issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cumulus Linux 5.x replaced NCLU (
net add/del) with NVUE (nv set/unset) as the primary CLI. ThencluAnsible module used by the existing provider is deprecated and fails with deserialization errors on ansible-core 2.20+.This commit updates all Cumulus provider task files to use NVUE commands via the
rawmodule:nv set bridge domain br_default vlannv unset bridge domain br_default vlannv set interface ... bridge domain br_default accessnv set interface ... bridge domain br_defaultnv unset interface ... bridge domain+ link state downAdditionally,
add_trunk_vlananddelete_trunk_vlanwhich were previously unimplemented ("not implimented") are now functional using NVUE.Tested against Cumulus VX 5.3.0 in a Containerlab environment.