Skip to content

Add deployment tracking#475

Merged
heueristik merged 9 commits intonext-bindingsfrom
deployment-tracking
Apr 24, 2026
Merged

Add deployment tracking#475
heueristik merged 9 commits intonext-bindingsfrom
deployment-tracking

Conversation

@jonaprieto
Copy link
Copy Markdown
Contributor

No description provided.

@jonaprieto jonaprieto requested a review from cwgoes February 19, 2026 07:22
@jonaprieto jonaprieto marked this pull request as ready for review February 22, 2026 00:45
@jonaprieto jonaprieto requested a review from agureev February 24, 2026 14:55
@jonaprieto jonaprieto added the enhancement New feature or request label Feb 24, 2026
cwgoes
cwgoes previously approved these changes Mar 6, 2026
Copy link
Copy Markdown
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tracking mechanism here LGTM, the file itself needs to be updated with the latest deployments.

@jonaprieto jonaprieto marked this pull request as draft April 8, 2026 04:41
@jonaprieto jonaprieto force-pushed the deployment-tracking branch from 9cb9198 to 822cc76 Compare April 10, 2026 05:14
@heueristik heueristik force-pushed the deployment-tracking branch from 42b7354 to 9f54c08 Compare April 10, 2026 11:48
@jonaprieto jonaprieto marked this pull request as ready for review April 10, 2026 12:02
Comment thread RELEASE_CHECKLIST.md Outdated
Comment thread deployments.json Outdated
Comment thread RELEASE_CHECKLIST.md Outdated
Comment thread RELEASE_CHECKLIST.md Outdated
Comment thread RELEASE_CHECKLIST.md Outdated
jonaprieto and others added 6 commits April 24, 2026 15:54
Seed the JSON file from the current hardcoded addresses in
`bindings/src/addresses.rs`. This will become the single source of
truth for deployment data in the next commits.
Replace the hardcoded HashMap in `addresses.rs` with `include_str!`
+ `serde_json` parsing of `deployments.json`. The JSON is embedded
at compile time — no scripts or codegen needed. Public API unchanged.
Validate that all entries have known chain IDs, valid addresses,
no duplicate chain IDs, and that the parsed map matches the JSON.
Replace references to editing `addresses.rs` with instructions
to edit `deployments.json`, including JSON format examples and
notes that validation is handled by existing `just` commands.
@heueristik heueristik force-pushed the deployment-tracking branch from 9f54c08 to b02e392 Compare April 24, 2026 14:06
@heueristik heueristik closed this Apr 24, 2026
@heueristik heueristik reopened this Apr 24, 2026
@heueristik heueristik changed the base branch from main to next-bindings April 24, 2026 14:19
@heueristik heueristik force-pushed the deployment-tracking branch from fb27b02 to 2beb49b Compare April 24, 2026 14:23
@jonaprieto
Copy link
Copy Markdown
Contributor Author

LGTM

@heueristik heueristik merged commit 466899a into next-bindings Apr 24, 2026
2 checks passed
@heueristik heueristik deleted the deployment-tracking branch April 24, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store and parse deployment addresses in and from a .json file

3 participants