Skip to content

Fix scroll thomb length changing on cards /tags lists of different size rows on bug #21367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amoniaka-knabino wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Fix scroll thomb length changing on cards /tags lists of different size rows on bug #21367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
addf2a9
Stabilize browser scrollbar thumb size
amoniaka-knabino Jul 11, 2026
0bd67a1
Try stabilize scrollbar thumb position
amoniaka-knabino Jul 11, 2026
a93b8ed
refactor
amoniaka-knabino Jul 12, 2026
981be0e
add comment
amoniaka-knabino Jul 12, 2026
f508abc
add comment to getCachedVisibleItemCount and getCachedHandleHeight funcs
amoniaka-knabino Jul 12, 2026
99e2579
add comment to getScrollProportion
amoniaka-knabino Jul 12, 2026
82eba9e
Switch tags to RecyclerFastScroller
amoniaka-knabino Jul 12, 2026
13409ed
Merge branch 'main' into fix-scroll-thomb
amoniaka-knabino Jul 13, 2026
a54f144
apply criticalay patch + remove resolve confict artifacts
amoniaka-knabino Jul 13, 2026
4a38ab9
null safe to attachFastScroller
amoniaka-knabino Jul 13, 2026
680e705
apply criticalAY patch 2
amoniaka-knabino Jul 14, 2026
bbef5ae
cache scroll offset and range
amoniaka-knabino Jul 14, 2026
070a523
add more comments
amoniaka-knabino Jul 14, 2026
16c681c
add scroll calibration to make scroll in the end correct and smooth
amoniaka-knabino Jul 15, 2026
a34c549
update only on content change, ignore itemrangechange (fixes scroll t…
amoniaka-knabino Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/dialogs/tags/TagsDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import com.ichi2.anki.libanki.NoteId
import com.ichi2.anki.libanki.withCollapsedWhitespace
import com.ichi2.anki.model.CardStateFilter
import com.ichi2.anki.snackbar.showSnackbar
import com.ichi2.anki.ui.attachFastScroller
import com.ichi2.anki.utils.ext.requireParcelable
import com.ichi2.ui.AccessibleSearchView
import com.ichi2.utils.DisplayUtils.resizeWhenSoftInputShown
Expand Down Expand Up @@ -230,6 +231,7 @@ class TagsDialog : AnalyticsDialogFragment {

tagsArrayAdapter = TagsArrayAdapter(tags) { binding.root.showMaxTagSelectedNotice(tags) }
binding.tagsList.adapter = tagsArrayAdapter
binding.tagsList.attachFastScroller(R.id.tags_scroller)

@sanjaysargam sanjaysargam Jul 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is scroller ID is not found ? It may crash
worth adding a null safe

@amoniaka-knabino amoniaka-knabino Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thank you. I made attachFastScroller null safe

if (tags.isEmpty) {
binding.noTagsTextView.visibility = View.VISIBLE
}
Expand Down
Loading
Loading